All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: George Spelvin <linux@horizon.com>
Cc: gnehzuil.liu@gmail.com, linux-ext4@vger.kernel.org
Subject: Re: debugfs: dump a sparse file as a new sparse file
Date: Tue, 1 Jan 2013 17:47:40 -0500	[thread overview]
Message-ID: <20130101224740.GD12554@thunk.org> (raw)
In-Reply-To: <20130101212504.11364.qmail@science.horizon.com>

On Tue, Jan 01, 2013 at 04:25:04PM -0500, George Spelvin wrote:
> 
> That's a good enough reason; my only remaining objection is calling it
> "a non-standard/non-portable GCC extension".

Fair enough.  Basically, e2fsprogs is targetting C89, and with the
exception of inline functions (which is optional; e2fsprogs will build
on compilers which don't handle inline functions, and it's only
recently that I switched us over to use C99 inline functions instead
of the old gcc's gnu89 inline declarations), as far as I know we're
not dependent on any C99 language features.

Because I tend to use a very conservative coding standard for
porability's sake, I sometimes lose track of what's actually allowed
by C99, and what's a GCC extension.

BTW, I'll note that in C11 (ISO/IEC 9899:2011), VLA's have been made
**optional**.  Hence, even for programs targetting C11-compliant
compilers, it's still not a good idea to use VLA's in your code if you
are striving for maximal portability.

Regards,

	      		      	    	 - Ted

      reply	other threads:[~2013-01-01 22:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-14  4:07 debugfs feature request: dump sparse files as sparse George Spelvin
2012-11-15 14:46 ` [PATCH] debugfs: dump a sparse file as a new sparse file Zheng Liu
2013-01-01  2:08   ` Theodore Ts'o
2013-01-01 12:33     ` Zheng Liu
2013-01-01 20:10     ` George Spelvin
2013-01-01 20:57       ` Theodore Ts'o
2013-01-01 21:25         ` George Spelvin
2013-01-01 22:47           ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130101224740.GD12554@thunk.org \
    --to=tytso@mit.edu \
    --cc=gnehzuil.liu@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux@horizon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.