From: Mike Frysinger <vapier@gentoo.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] build: resolve link failure for ip6t_NETMAP
Date: Tue, 1 Jan 2013 23:03:51 -0500 [thread overview]
Message-ID: <201301012303.52249.vapier@gentoo.org> (raw)
In-Reply-To: <1356933246-20336-1-git-send-email-jengelh@inai.de>
[-- Attachment #1: Type: Text/Plain, Size: 979 bytes --]
On Monday 31 December 2012 00:54:06 Jan Engelhardt wrote:
> Like this? We cannot really get rid of mentioning .libs without involving
> libltdl, and there I really do not want to go.
why ? are the modules run directly out of the build tree, or you just need to
install them ? `libtool --mode=install` can install an .la file ...
> + ${AM_VERBOSE_NULL} ln -fs .libs/$@ $@;
i'm not sure why a lot of these rules have trailing semi-colons. they're
pointless.
> + ${AM_VERBOSE_CCLD} ../libtool ${AM_LIBTOOL_SILENT} --tag=CC --mode=link
> ${CCLD} ${AM_LDFLAGS} -module ${LDFLAGS} -o $@ $< -L../libxtables
> -lxtables ${$*_LIBADD} -rpath ${xtlibdir};
should be ../libxtables/libxtables.la rather than -L/-l for libxtables
> libxt_NOTRACK.so: libxt_CT.so
> ln -fs $< $@
> libxt_state.so: libxt_conntrack.so
> ln -fs $< $@
these two rules could use your new $AM_VERBOSE_NULL
otherwise, this is an improvement imo over the existing code
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-01-02 4:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-30 23:11 [PATCH] extensions: fix linking against -lip6tc Mike Frysinger
2012-12-30 23:38 ` Pablo Neira Ayuso
2012-12-31 0:51 ` Mike Frysinger
2012-12-31 5:54 ` [PATCH] build: resolve link failure for ip6t_NETMAP Jan Engelhardt
2013-01-02 4:03 ` Mike Frysinger [this message]
2013-01-02 8:42 ` Jan Engelhardt
2013-01-02 8:47 ` Jan Engelhardt
2013-01-02 17:23 ` Mike Frysinger
2013-01-02 23:50 ` Pablo Neira Ayuso
2013-01-11 23:34 ` Dmitry V. Levin
2013-01-12 0:00 ` Dmitry V. Levin
2013-01-12 1:37 ` Jan Engelhardt
-- strict thread matches above, loose matches on Subject: below --
2012-12-02 18:16 Jan Engelhardt
2012-12-03 13:12 ` Pablo Neira Ayuso
2012-12-03 15:58 ` Jan Engelhardt
2012-12-04 12:16 ` Pablo Neira Ayuso
2012-12-04 13:42 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301012303.52249.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.