All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	William Hubbs <w.d.hubbs@gmail.com>,
	Chris Brannon <chris@the-brannons.com>,
	Kirk Reiser <kirk@braille.uwo.ca>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH,staging/speakup] Prefix externally-visible symbols
Date: Tue, 1 Jan 2013 17:17:22 -0800	[thread overview]
Message-ID: <20130102011722.GA25903@kroah.com> (raw)
In-Reply-To: <20130101225257.GC6582@type.youpi.perso.aquilenet.fr>

On Tue, Jan 01, 2013 at 11:52:57PM +0100, Samuel Thibault wrote:
> This prefixes all externally-visible symbols of speakup with "spk_".
> (or makes static some of them which do not actually need to be
> externally-visible)

Care to break this up into smaller pieces?  Like one for the variables
that should just be static?  And then the other bits?

Also, I think you just changed user-visable variables/sysfs files, which
isn't acceptable.  Be careful about that when you resend.

thanks,

greg k-h

  reply	other threads:[~2013-01-02  1:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-01 22:52 [PATCH,staging/speakup] Prefix externally-visible symbols Samuel Thibault
2013-01-02  1:17 ` Greg Kroah-Hartman [this message]
2013-01-02  1:38   ` Samuel Thibault
2013-01-02  2:04     ` Greg Kroah-Hartman
2013-01-02  1:36 ` [PATCH,staging/speakup] Turn some symbols static Samuel Thibault
2013-01-02  1:37 ` [PATCH,staging/speakup] Prefix externally-visible symbols Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130102011722.GA25903@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chris@the-brannons.com \
    --cc=kirk@braille.uwo.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=w.d.hubbs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.