From: Solomon Peachy <pizza@shaftnet.org>
To: Bob Copeland <me@bobcopeland.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 11/17] cw1200: v2: WSM (ie host-firmware) host interface
Date: Wed, 2 Jan 2013 10:07:24 -0500 [thread overview]
Message-ID: <20130102150724.GA3371@shaftnet.org> (raw)
In-Reply-To: <20130102143708.GA13185@localhost>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Wed, Jan 02, 2013 at 09:37:08AM -0500, Bob Copeland wrote:
> I think this should be
>
> size = round_up(size, FWLOAD_BLOCK_SIZE);
>
> Otherwise it fails if size > 2 * FWLOAD_BLOCK_SIZE (it may never be,
> but it still looks wrong).
Good catch! I'd already fixed a couple of code constructs like this.
(I'll probably have a v3 patch submission this weekend. Contributions
coming out of the woodwork, plus more cleanups and improvements..)
- Solomon
--
Solomon Peachy pizza at shaftnet dot org
Melbourne, FL ^^ (mail/jabber/gtalk) ^^
Quidquid latine dictum sit, altum viditur.
[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2013-01-02 15:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-22 23:18 RFCv2: ST-E cw1200 driver Solomon Peachy
2012-12-22 23:18 ` [PATCH 01/17] cw1200: v2: low-level hardware I/O functions Solomon Peachy
2012-12-22 23:18 ` [PATCH 02/17] cw1200: v2: internal tx queue tracking and handling Solomon Peachy
2012-12-22 23:18 ` [PATCH 03/17] cw1200: v2: Scan implementation Solomon Peachy
2012-12-22 23:18 ` [PATCH 04/17] cw1200: v2: power management Solomon Peachy
2012-12-22 23:18 ` [PATCH 05/17] cw1200: v2: firmware loading Solomon Peachy
2012-12-22 23:18 ` [PATCH 06/17] cw1200: v2: mini-ap support code Solomon Peachy
2012-12-22 23:18 ` [PATCH 07/17] cw1200: v2: debuging hooks Solomon Peachy
2012-12-22 23:18 ` [PATCH 08/17] cw1200: v2: test tool support Solomon Peachy
2012-12-22 23:18 ` [PATCH 09/17] cw1200: v2: 802.11 station api Solomon Peachy
2012-12-22 23:18 ` [PATCH 10/17] cw1200: v2: packet transmit/receive handling Solomon Peachy
2012-12-22 23:18 ` [PATCH 11/17] cw1200: v2: WSM (ie host-firmware) host interface Solomon Peachy
2013-01-02 14:37 ` Bob Copeland
2013-01-02 15:07 ` Solomon Peachy [this message]
2012-12-22 23:18 ` [PATCH 12/17] cw1200: v2: main processing loop Solomon Peachy
2012-12-22 23:18 ` [PATCH 13/17] cw1200: v2: common registration/setup code Solomon Peachy
2012-12-22 23:18 ` [PATCH 14/17] cw1200: v2: driver state and definitions Solomon Peachy
2012-12-22 23:18 ` [PATCH 15/17] cw1200: v2: SDIO and SPI glue code, and platform definitions Solomon Peachy
2012-12-22 23:18 ` [PATCH 16/17] cw1200: v2: kbuild integration Solomon Peachy
2012-12-22 23:18 ` [PATCH 17/17] cw1200: v2: add to drivers/staging Solomon Peachy
2012-12-24 19:00 ` RFCv2: ST-E cw1200 driver Solomon Peachy
2013-01-11 15:58 ` Solomon Peachy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130102150724.GA3371@shaftnet.org \
--to=pizza@shaftnet.org \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.