From: Andrew Morton <akpm@linux-foundation.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Marc Dietrich <marvin24@gmx.de>,
"akpm@linuxfoundation.org" <akpm@linuxfoundation.org>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH V2] rtc: add RTC driver for TPS6586x
Date: Wed, 2 Jan 2013 15:50:57 -0800 [thread overview]
Message-ID: <20130102155057.9fb6ede2.akpm@linux-foundation.org> (raw)
In-Reply-To: <50DC6242.1000404@nvidia.com>
On Thu, 27 Dec 2012 20:29:14 +0530
Laxman Dewangan <ldewangan@nvidia.com> wrote:
> On Thursday 27 December 2012 08:26 PM, Marc Dietrich wrote:
> > Hi Laxman,
> >
> > On Friday 21 December 2012 20:42:28 you wrote:
> >
> >> +
> >> + /* Set epoch start as 00:00:00:01:01:2000 */
> >> + rtc->epoch_start = mktime(2000, 1, 1, 0, 0, 0);
> > any reason why you hard coded it to 2000? All boards I know use 2009, so with
> > this patch, everyone needs to set his clock again.
> >
>
> No specific reason. If 2009 should be default then I can push patch to
> set it as 2009.
I'd like to get this into Linus soon so let's get it finished. I
assume it's merely this?
--- a/drivers/rtc/rtc-tps6586x.c~rtc-add-rtc-driver-for-tps6586x-fix2
+++ a/drivers/rtc/rtc-tps6586x.c
@@ -260,8 +260,8 @@ static int tps6586x_rtc_probe(struct pla
rtc->dev = &pdev->dev;
rtc->irq = platform_get_irq(pdev, 0);
- /* Set epoch start as 00:00:00:01:01:2000 */
- rtc->epoch_start = mktime(2000, 1, 1, 0, 0, 0);
+ /* Set epoch start as 00:00:00:01:01:2009 */
+ rtc->epoch_start = mktime(2009, 1, 1, 0, 0, 0);
/* 1 kHz tick mode, enable tick counting */
ret = tps6586x_update(tps_dev, RTC_CTRL,
_
next prev parent reply other threads:[~2013-01-02 23:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 15:12 [PATCH V2] rtc: add RTC driver for TPS6586x Laxman Dewangan
2012-12-27 14:56 ` Marc Dietrich
2012-12-27 14:59 ` Laxman Dewangan
2012-12-27 15:56 ` Marc Dietrich
2012-12-27 16:59 ` Laxman Dewangan
2013-01-02 23:50 ` Andrew Morton [this message]
2013-01-03 6:16 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130102155057.9fb6ede2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.zummo@towertech.it \
--cc=akpm@linuxfoundation.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=rtc-linux@googlegroups.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.