From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: Dave Reisner <dreisner@archlinux.org>,
LKML <linux-kernel@vger.kernel.org>,
Vasiliy Kulikov <segoon@openwall.com>
Subject: Re: [PATCH] debugfs: convert gid= argument from decimal, not octal
Date: Wed, 2 Jan 2013 10:57:47 -0800 [thread overview]
Message-ID: <20130102185747.GA28762@kroah.com> (raw)
In-Reply-To: <CAGXu5jJ1oGh-ExwQ6f0CMNQjF2cAcLrgWRCz8ho0v4Ve+GjOuw@mail.gmail.com>
On Wed, Jan 02, 2013 at 10:42:17AM -0800, Kees Cook wrote:
> On Wed, Jan 2, 2013 at 10:33 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Wed, Jan 02, 2013 at 08:54:37AM -0500, Dave Reisner wrote:
> >> This patch technically breaks userspace, but I suspect that anyone who
> >> actually used this flag would have encountered this brokenness, declared
> >> it lunacy, and already sent a patch.
> >
> > Kees is the one that originally did this change (I think, right?)
>
> I recommended the default change, but I think it was Vasiliy that
> added the gid option, IIRC.
Ah, you are right, sorry about that.
> > Kees, any objection to this patch? Will it break your existing systems?
>
> Regardless, I have no objection -- this should be int, not octal.
Ok, I'll queue this up when I get back from vacation next week.
thanks,
greg k-h
next prev parent reply other threads:[~2013-01-02 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 13:54 [PATCH] debugfs: convert gid= argument from decimal, not octal Dave Reisner
2013-01-02 18:33 ` Greg Kroah-Hartman
2013-01-02 18:42 ` Kees Cook
2013-01-02 18:57 ` Greg Kroah-Hartman [this message]
2013-01-02 19:06 ` [kernel-hardening] " Vasiliy Kulikov
2013-01-02 18:46 ` Dave Reisner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130102185747.GA28762@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dreisner@archlinux.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segoon@openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.