Re: [PATCH v4 3/3] PM: Introduce Intel PowerClamp Driver

[Jacob Pan <jacob.jun.pan@linux.intel.com>]

On Thu, 03 Jan 2013 11:34:14 -0800
Joe Perches <joe@perches.com> wrote:

> On Thu, 2013-01-03 at 03:01 -0800, Jacob Pan wrote:
> > Intel PowerClamp driver performs synchronized idle injection across
> > all online CPUs. The goal is to maintain a given package level
> > C-state ratio.
> 
> just trivia:
> 
> > diff --git a/drivers/thermal/intel_powerclamp.c
> > b/drivers/thermal/intel_powerclamp.c
> 
> > +static int clamping;
> 
> bool and use true/false?
sure. will change in v5
> 
> > +static int window_size_set(const char *arg, const struct
> > kernel_param *kp)
> []
> > +	if (new_window_size >= 10 || new_window_size < 2) {
> > +		pr_err("Invalid window size %lu, between 2-10\n",
> > +			new_window_size);
> 
> This is a misleading message or a bad test,
> It's from 2 to 9
> 
> This would more normally be tested/written as
> 
> 	val < low || val > high
> 
will change to make the range match error message, between 2 to 10.

Thanks,

Jacob