From: Stephen Hemminger <shemminger@vyatta.com>
To: Rami Rosen <ramirose@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, ebiederm@xmission.com
Subject: Re: [RFC PATCH net-next 3/3] vxlan: remove NETIF_F_NETNS_LOCAL from vxlan device features.
Date: Thu, 3 Jan 2013 07:45:03 -0800 [thread overview]
Message-ID: <20130103074503.3bafe61a@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1357205121-4700-4-git-send-email-ramirose@gmail.com>
On Thu, 3 Jan 2013 11:25:21 +0200
Rami Rosen <ramirose@gmail.com> wrote:
> There is no need for NETIF_F_NETNS_LOCAL for vxlan device; this patch removes it.
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
> drivers/net/vxlan.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 40f2cc1..385f743 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -1185,7 +1185,6 @@ static void vxlan_setup(struct net_device *dev)
>
> dev->tx_queue_len = 0;
> dev->features |= NETIF_F_LLTX;
> - dev->features |= NETIF_F_NETNS_LOCAL;
> dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM;
> dev->features |= NETIF_F_RXCSUM;
>
Vxlan works over UDP socket, and the UDP socket is part of the namespace
it is created in. Moving the vxlan device does not move that state.
prev parent reply other threads:[~2013-01-03 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 9:25 [RFC PATCH net-next 0/3] Remove NETIF_F_NETNS_LOCAL from software devices Rami Rosen
2013-01-03 9:25 ` [RFC PATCH net-next 1/3] ppp: remove NETIF_F_NETNS_LOCAL from ppp device features Rami Rosen
2013-01-03 9:25 ` [RFC PATCH net-next 2/3] bridge: remove NETIF_F_NETNS_LOCAL from bridge " Rami Rosen
2013-01-03 9:25 ` [RFC PATCH net-next 3/3] vxlan: remove NETIF_F_NETNS_LOCAL from vxlan " Rami Rosen
2013-01-03 15:45 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130103074503.3bafe61a@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=ramirose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.