From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH v2] tcp: split tcp_ecn sysctl knob to distinguish
 between IPv4 and IPv6
Date: Thu, 3 Jan 2013 08:22:54 -0800
Message-ID: <20130103082254.770d4222@nehalam.linuxnetplumber.net>
References: <20130103000009.GG4464@order.stressinduktion.org>
	<20130103122844.GH4464@order.stressinduktion.org>
	<20130103.045350.1322196416782379673.davem@davemloft.net>
	<20130103125812.GJ4464@order.stressinduktion.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.vyatta.com ([76.74.103.46]:40369 "EHLO mail.vyatta.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753404Ab3ACQYW (ORCPT <rfc822;netdev@vger.kernel.org>);
	Thu, 3 Jan 2013 11:24:22 -0500
In-Reply-To: <20130103125812.GJ4464@order.stressinduktion.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 3 Jan 2013 13:58:12 +0100
Hannes Frederic Sowa <hannes@stressinduktion.org> wrote:

> On Thu, Jan 03, 2013 at 04:53:50AM -0800, David Miller wrote:
> > From: Hannes Frederic Sowa <hannes@stressinduktion.org>
> > Date: Thu, 3 Jan 2013 13:28:44 +0100
> > 
> > > On Thu, Jan 03, 2013 at 01:00:09AM +0100, Hannes Frederic Sowa wrote:
> > >> ECN could be more reliable when used with IPv6 (I don't have proofs). For
> > >> people who want to try ECN with IPv6 but still have problems connecting
> > >> to destinations because of broken IPv4 routers this switch allows one
> > >> to enable ECN just for IPv6.
> > >> 
> > >> Perhaps ECN could be enabled by default in future.
> > >> 
> > >> No code changes since initial submission, just added documentation.
> > > 
> > > May I ask what lead to the rejection of the patch?
> > 
> > I don't see any value in splitting up ipv4 and ipv6.
> > 
> > I think we should turn the existing knob on unliaterally
> > by default.  That would be a much better patch.
> 
> Oh, I would be happy to do that. :)

Perhaps, ECN should be a property of the route.
There is RTAX_FEATURE_ECN but it appears to have been lost
as part of the removal of route cache.