From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] Add Perf tools support
Date: Thu, 3 Jan 2013 11:23:06 +0100 [thread overview]
Message-ID: <20130103112306.0d0ef1c6@skate> (raw)
In-Reply-To: <CAPDLWs-otw90dvsw7oVra=-+oNJZ0-SeiXE1CoXh1WUxNhq2vQ@mail.gmail.com>
Dear Kaiwan Billimoria,
On Thu, 3 Jan 2013 13:20:39 +0530, Kaiwan Billimoria wrote:
> + # FIXME: Where should we place the perf kernel patch? Online?
> + # Temporarily, at least, it's under linux/
> + BR2_LINUX_KERNEL_PATCH += "$(HOST_DIR)/../../linux/perf.patch"
No, we don't modify BR2 variables.
> +all:
Arggh, this is *horrible*. Why do you believe you are allowed to
overload the "all" target?
> + $(info Building Perf...)
> + $(TARGET_MAKE_ENV) $(MAKE) ARCH=$(ARCH)
> CROSS_COMPILE=$(TARGET_CROSS) NO_LIBELF=1 -C $(LINUX_DIR)/tools/perf
This should be part of LINUX_BUILD_CMDS
> + # Perf: Copy the perf binary executable to the target rootfs
> + cp -f $(LINUX_DIR)/tools/perf/perf $(TARGET_DIR)/usr/sbin
This should be part of LINUX_INSTALL_TARGET_CMDS
And doing that will help you solve the problem you mentioned in your
cover letter ("the 'perf' binary executable is being built after the
root filesystem is tar-red").
That said, I am not sure we want this thing in linux/linux.mk. Maybe
I'd prefer a package/perf/perf.mk, which depends on BR2_LINUX_KERNEL
and re-uses the source code extracted in $(LINUX_DIR).
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-01-03 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 7:50 [Buildroot] [PATCH 2/3] Add Perf tools support Kaiwan Billimoria
2013-01-03 10:23 ` Thomas Petazzoni [this message]
2013-01-03 12:54 ` Kaiwan Billimoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130103112306.0d0ef1c6@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.