From: Patrick McHardy <kaber@trash.net>
To: Ulrich Weber <ulrich.weber@sophos.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: fix IPv6 NTP checksum calculation
Date: Fri, 4 Jan 2013 10:20:43 +0100 [thread overview]
Message-ID: <20130104092042.GB28028@macbook.localnet> (raw)
In-Reply-To: <20130102152440.GA3760@uweber-WS>
On Wed, Jan 02, 2013 at 04:24:40PM +0100, Ulrich Weber wrote:
> csum16_add() has a broken carry detection, should be:
> sum += sum < (__force u16)b;
>
> Instead of fixing csum16_add, remove the custom checksum
> functions and use the generic csum_add/csum_sub ones.
Looks good to me.
Acked-by: Patrick McHardy <kaber@trash.net>
next prev parent reply other threads:[~2013-01-04 9:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 15:24 [PATCH] netfilter: fix IPv6 NTP checksum calculation Ulrich Weber
2013-01-04 9:20 ` Patrick McHardy [this message]
2013-01-04 19:22 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2013-01-24 17:09 Jean-Michel DILLY
2013-01-24 22:49 ` Florian Westphal
2013-01-25 21:09 ` Jean-Michel DILLY
2013-01-26 16:29 ` YOSHIFUJI Hideaki
2013-01-29 14:50 ` Ulrich Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130104092042.GB28028@macbook.localnet \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=ulrich.weber@sophos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.