All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: meta-freescale@yoctoproject.org
Cc: Andrei Gherzan <andrei.gherzan@windriver.com>
Subject: Re: [meta-fsl-arm][PATCH 1/2] barebox: Add defconfig only for imx53qsb
Date: Fri, 4 Jan 2013 14:48:22 +0100	[thread overview]
Message-ID: <20130104144822.5385bfb3@e6520eb> (raw)
In-Reply-To: <1357303747-20056-1-git-send-email-andrei.gherzan@windriver.com>

Hi Andrei,

Le Fri, 4 Jan 2013 14:49:06 +0200,
Andrei Gherzan <andrei.gherzan@windriver.com> a écrit :

> Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
> ---
>  recipes-bsp/barebox/barebox_2012.02.0.bb |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes-bsp/barebox/barebox_2012.02.0.bb b/recipes-bsp/barebox/barebox_2012.02.0.bb
> index 3fad26f..0ba260f 100644
> --- a/recipes-bsp/barebox/barebox_2012.02.0.bb
> +++ b/recipes-bsp/barebox/barebox_2012.02.0.bb
> @@ -1,11 +1,12 @@
>  require barebox.inc
>  
> -PR = "r1"
> +PR = "r2"
>  
>  SRC_URI = "http://barebox.org/download/${PN}-${PV}.tar.bz2 \
> -	file://defconfig \
>  	"
>  
> +SRC_URI_append_imx53qsb = " file://defconfig"
> +
>  SRC_URI[md5sum] = "ce876bb3ba1f60b5ee08f13dc648f702"
>  SRC_URI[sha256sum] = "5cd1fcbd6596d3fad1b25a79706a9a76508e8c0d2a85e79ef2d91754caa6667b"
>  
I would prefer that you add a COMPATIBLE_MACHINE = "imx53qsb" as the
defconfig is generic for all supported boards and not specific to a
board.

Thanks
Eric


  parent reply	other threads:[~2013-01-04 13:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-04 12:49 [meta-fsl-arm][PATCH 1/2] barebox: Add defconfig only for imx53qsb Andrei Gherzan
2013-01-04 12:49 ` [meta-fsl-arm][PATCH 2/2] xorg-driver-video: Install vivante_gal.h Andrei Gherzan
2013-01-04 21:55   ` Otavio Salvador
2013-01-04 13:48 ` Eric Bénard [this message]
2013-01-04 13:58   ` [meta-fsl-arm][PATCH 1/2] barebox: Add defconfig only for imx53qsb Andrei Gherzan
2013-01-04 15:47     ` Eric Bénard
2013-01-04 15:51       ` Andrei Gherzan
2013-01-04 16:20   ` Eric Bénard
2013-01-04 22:25     ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130104144822.5385bfb3@e6520eb \
    --to=eric@eukrea.com \
    --cc=andrei.gherzan@windriver.com \
    --cc=meta-freescale@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.