From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Devin Heitmueller <dheitmueller@kernellabs.com>,
Hans Verkuil <hans.verkuil@cisco.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 10/15] em28xx: fix broken TRY_FMT.
Date: Sat, 5 Jan 2013 00:54:44 -0200 [thread overview]
Message-ID: <20130105005444.361b2604@redhat.com> (raw)
In-Reply-To: <1357333186-8466-11-git-send-email-dheitmueller@kernellabs.com>
Hans/Devin,
Em Fri, 4 Jan 2013 15:59:40 -0500
Devin Heitmueller <dheitmueller@kernellabs.com> escreveu:
> TRY_FMT should not return an error if a pixelformat is unsupported. Instead just
> pick a common pixelformat.
>
> Also the bytesperline calculation was incorrect: it used the old width instead of
> the provided with, and it miscalculated the bytesperline value for the depth == 12
> case.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
> ---
> drivers/media/usb/em28xx/em28xx-video.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c
> index a91a248..7c09b55 100644
> --- a/drivers/media/usb/em28xx/em28xx-video.c
> +++ b/drivers/media/usb/em28xx/em28xx-video.c
> @@ -821,7 +821,7 @@ static int vidioc_try_fmt_vid_cap(struct file *file, void *priv,
> if (!fmt) {
> em28xx_videodbg("Fourcc format (%08x) invalid.\n",
> f->fmt.pix.pixelformat);
> - return -EINVAL;
> + fmt = format_by_fourcc(V4L2_PIX_FMT_YUYV);
This change has the potential of causing userspace regressions, so,
for now, I won't apply such change.
We need to discuss it better, before risk breaking things, and likely fix
applications first.
Regards,
Mauro
next prev parent reply other threads:[~2013-01-05 2:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 20:59 [PATCH 00/15] em28xx VBI2 port and v4l2-compliance fixes Devin Heitmueller
2013-01-04 20:59 ` [PATCH 01/15] em28xx: fix querycap Devin Heitmueller
2013-01-04 20:59 ` [PATCH 02/15] em28xx: remove bogus input/audio ioctls for the radio device Devin Heitmueller
2013-01-04 20:59 ` [PATCH 03/15] em28xx: fix VIDIOC_DBG_G_CHIP_IDENT compliance errors Devin Heitmueller
2013-01-04 20:59 ` [PATCH 04/15] em28xx: fix tuner/frequency handling Devin Heitmueller
2013-01-04 20:59 ` [PATCH 05/15] v4l2-ctrls: add a notify callback Devin Heitmueller
2013-01-04 20:59 ` [PATCH 06/15] em28xx: convert to the control framework Devin Heitmueller
2013-01-04 20:59 ` [PATCH 07/15] em28xx: convert to v4l2_fh, fix priority handling Devin Heitmueller
2013-01-04 20:59 ` [PATCH 08/15] em28xx: add support for control events Devin Heitmueller
2013-01-04 20:59 ` [PATCH 09/15] em28xx: fill in readbuffers and fix incorrect return code Devin Heitmueller
2013-01-04 20:59 ` [PATCH 10/15] em28xx: fix broken TRY_FMT Devin Heitmueller
2013-01-05 2:54 ` Mauro Carvalho Chehab [this message]
2013-01-05 13:34 ` Hans Verkuil
2013-01-05 15:36 ` Mauro Carvalho Chehab
2013-01-04 20:59 ` [PATCH 11/15] tvp5150: remove compat control ops Devin Heitmueller
2013-01-04 20:59 ` [PATCH 12/15] em28xx: std fixes: don't implement in webcam mode, and fix std changes Devin Heitmueller
2013-01-04 20:59 ` [PATCH 13/15] em28xx: remove sliced VBI support Devin Heitmueller
2013-01-04 20:59 ` [PATCH 14/15] em28xx: zero vbi_format reserved array and add try_vbi_fmt Devin Heitmueller
2013-01-04 20:59 ` [PATCH 15/15] em28xx: convert to videobuf2 Devin Heitmueller
2013-01-08 18:40 ` Frank Schäfer
2013-01-08 18:59 ` Devin Heitmueller
2013-01-04 21:04 ` [PATCH 00/15] em28xx VBI2 port and v4l2-compliance fixes Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130105005444.361b2604@redhat.com \
--to=mchehab@redhat.com \
--cc=dheitmueller@kernellabs.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.