From: Karel Zak <kzak@redhat.com>
To: Miloslav Trmac <mitr@redhat.com>
Cc: Cody Maloney <cmaloney@theoreticalchaos.com>, util-linux@vger.kernel.org
Subject: Re: [PATCH 3/3] chsh: Add libuser support
Date: Mon, 7 Jan 2013 12:51:03 +0100 [thread overview]
Message-ID: <20130107115103.GD28963@x2.redhat.com> (raw)
In-Reply-To: <805019865.52854570.1357230851238.JavaMail.root@redhat.com>
On Thu, Jan 03, 2013 at 11:34:11AM -0500, Miloslav Trmac wrote:
> > + memset(&val, 0, sizeof(val));
> > + g_value_init(&val, G_TYPE_STRING);
> > + g_value_set_string(&val, shell);
> > +
> > + lu_ent_clear(ent, LU_LOGINSHELL);
> > + lu_ent_add(ent, LU_LOGINSHELL, &val);
> If you don't mind depending on libuser >= 0.58, all of the above can be replaced with
> > lu_ent_set_string(ent, LU_LOGINSHELL, shell);
> and you can drop the "g_value_unset" calls as well.
It would be nice to drop g_* junk :-)
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2013-01-07 11:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-13 9:12 [PATCH v2 0/4] Add support for using libuser to chsh and chfn Cody Maloney
2013-01-03 3:21 ` [PATCH 0/3] Add support for using libuser to chsh Cody Maloney
2013-01-03 3:21 ` [PATCH 1/3] chsh-chfn: Add flag for enabling/disabling libuser support Cody Maloney
2013-01-03 3:22 ` [PATCH 2/3] chsh: Move pam auth to its own function Cody Maloney
2013-01-03 3:22 ` [PATCH 3/3] chsh: Add libuser support Cody Maloney
2013-01-03 16:34 ` Miloslav Trmac
2013-01-07 11:51 ` Karel Zak [this message]
2013-01-08 6:15 ` Cody Maloney
2013-01-08 6:17 ` Cody Maloney
2013-01-08 6:18 ` Cody Maloney
2013-01-13 9:12 ` [PATCH 2/3] chsh: Move pam auth to its own function Cody Maloney
2013-01-13 9:12 ` [PATCH v2 1/4] chsh-chfn: Add flag for enabling/disabling libuser support Cody Maloney
2013-01-13 9:12 ` [PATCH v2 2/4] chsh-chfn: Move pam auth to its own function, factoring out common code Cody Maloney
2013-01-13 9:12 ` [PATCH v2 3/4] chsh: Add libuser support Cody Maloney
2013-01-14 18:16 ` Miloslav Trmac
2013-01-17 0:52 ` Cody Maloney
2013-01-28 22:01 ` Miloslav Trmac
2013-01-13 9:12 ` [PATCH v2 4/4] chfn: " Cody Maloney
[not found] ` <50F2FBBE.7000305@gmail.com>
2013-01-13 19:31 ` [PATCH v2 0/4] Add support for using libuser to chsh and chfn Cody Maloney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107115103.GD28963@x2.redhat.com \
--to=kzak@redhat.com \
--cc=cmaloney@theoreticalchaos.com \
--cc=mitr@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.