From: Martin Jansa <martin.jansa@gmail.com>
To: Kang Kai <kai.kang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [oe-commits] Kang Kai : perl: update dependency creating script
Date: Mon, 7 Jan 2013 13:29:49 +0100 [thread overview]
Message-ID: <20130107122949.GD3285@jama> (raw)
In-Reply-To: <20130107113603.F0F381034A@opal>
[-- Attachment #1: Type: text/plain, Size: 2400 bytes --]
On Mon, Jan 07, 2013 at 11:36:03AM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: 35291c97edc05756788d206457c56dcc41edb637
> URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=35291c97edc05756788d206457c56dcc41edb637
>
> Author: Kang Kai <kai.kang@windriver.com>
> Date: Mon Nov 5 10:42:00 2012 +0800
>
> perl: update dependency creating script
>
> Base on dependency create script provided by Saul, I update it with:
> 1 remove document strings in perl module files that may import fake
> dependencies.
>
> 2 not all the 'use' or 'require' clauses start at the begin of line, and
> some of them don't end with ';', such as:
>
> use vars qw(
> $AUTOLOAD
> ...
>
> 3 filter some strings that they are not real dependencies: some of them
> are wrong result of script, some are conditional use/require, and some
> are cpan extra modules that we don't need.
>
> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
This breaks parsing when
http://patchwork.openembedded.org/patch/40997/
is used.
Parsing recipes...ERROR: There is a confusing multiline, partially commented expression on line 10 of file /OE/shr-core/openembedded-core/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc (| sed "s/\/.*\.pm: */ += /g;s/[\"\']//g;s/;.*/\"/g;s/+= .*\(require\|use\)\> */+= \"perl-module-/g;s/CPANPLUS::.*/cpanplus/g;s/CPAN::.*/cpan/g;s/::/-/g;s/ [^+\"].*//g;s/_/-/g;s/\.pl\"$/\"/;s/\"\?\$/\"/;s/(//;" | tr [:upper:] [:lower:] \).
Please clarify whether this is all a comment or should be parsed.
ERROR: Unable to parse /OE/shr-core/openembedded-core/meta/recipes-devtools/perl/perl_5.14.2.bb: Exited with "1"
ERROR: Command execution failed: Exited with 1
>
> ---
>
> .../recipes-devtools/perl/perl-rdepends_5.14.2.inc | 2336 +++++++++++++++++++-
> 1 files changed, 2287 insertions(+), 49 deletions(-)
>
> Diff: http://git.openembedded.org/?p=openembedded-core.git/?a=commitdiff;h=35291c97edc05756788d206457c56dcc41edb637
>
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next parent reply other threads:[~2013-01-07 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130107113603.F0F381034A@opal>
2013-01-07 12:29 ` Martin Jansa [this message]
2013-01-14 3:02 ` [oe-commits] Kang Kai : perl: update dependency creating script Kang Kai
2013-01-14 8:14 ` Martin Jansa
2013-01-14 9:39 ` Kang Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107122949.GD3285@jama \
--to=martin.jansa@gmail.com \
--cc=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.