From: Vinod Koul <vinod.koul@intel.com>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Anmar Oueja <anmar.oueja@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 0/8] DMA: COH901318 in-factoring of platform
Date: Mon, 7 Jan 2013 06:59:25 -0800 [thread overview]
Message-ID: <20130107145925.GC15804@intel.com> (raw)
In-Reply-To: <1357512185-5562-1-git-send-email-linus.walleij@stericsson.com>
On Sun, Jan 06, 2013 at 11:43:05PM +0100, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> This patch series moves the big, complex platform data for the U300
> DMA controller COH901318 down into the driver, rids the
> <mach/coh901318.h> header from the global scope, creates a proper
> platform data header for the few things we acually want to
> parametrize from the platform, and all in preparation for device
> tree support.
>
> Vinod, it'd be great if you could ACK this so I can merge it
> through the ARM SoC tree. The driver is propably more maintainable
> in this shape as well without lots of pieces spread out all over
> the place.
Sure the change look fine and mostly seems to be code reorg and cleanup.
Perhpas the below diffstat could have helped in review if it showed file move
Acked-by: Vinod Koul <vinod.koul@intel.com>
>
> Linus Walleij (8):
> dma: coh901318: create a proper platform data file
> dma: coh901318: push platform data into driver
> dma: coh901318: remove hardcoded target addresses
> dma: coh901318: skip hard-coded addresses
> dma: coh901318: push header down into the DMA subsystem
> dma: coh901318: push definitions into driver
> dma: coh901318: merge header files
> dma: coh901318: cut down on platform data abstraction
>
> arch/arm/mach-u300/core.c | 1087 +---------------------
> arch/arm/mach-u300/dma_channels.h | 60 --
> arch/arm/mach-u300/include/mach/coh901318.h | 267 ------
> arch/arm/mach-u300/spi.c | 3 +-
> drivers/dma/coh901318.c | 1302 ++++++++++++++++++++++++++-
> drivers/dma/coh901318.h | 141 +++
> drivers/dma/coh901318_lli.c | 4 +-
> drivers/dma/coh901318_lli.h | 124 ---
> include/linux/platform_data/dma-coh901318.h | 72 ++
> 9 files changed, 1469 insertions(+), 1591 deletions(-)
> delete mode 100644 arch/arm/mach-u300/dma_channels.h
> delete mode 100644 arch/arm/mach-u300/include/mach/coh901318.h
> create mode 100644 drivers/dma/coh901318.h
> delete mode 100644 drivers/dma/coh901318_lli.h
> create mode 100644 include/linux/platform_data/dma-coh901318.h
>
> --
> 1.7.11.3
>
prev parent reply other threads:[~2013-01-07 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 22:43 [PATCH 0/8] DMA: COH901318 in-factoring of platform Linus Walleij
2013-01-07 14:59 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107145925.GC15804@intel.com \
--to=vinod.koul@intel.com \
--cc=anmar.oueja@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.