From mboxrd@z Thu Jan  1 00:00:00 1970
From: andrew@lunn.ch (Andrew Lunn)
Date: Mon, 7 Jan 2013 16:27:39 +0100
Subject: [PATCH 01/11] ARM: Kirkwood: Fix missing clk for USB device.
In-Reply-To: <20130107151138.GJ1357@kw.sim.vm.gnt>
References: <1357467044-4914-1-git-send-email-andrew@lunn.ch>
 <1357467044-4914-2-git-send-email-andrew@lunn.ch>
 <20130107151138.GJ1357@kw.sim.vm.gnt>
Message-ID: <20130107152739.GA3392@lunn.ch>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Mon, Jan 07, 2013 at 04:11:38PM +0100, Simon Guinot wrote:
> On Sun, Jan 06, 2013 at 11:10:34AM +0100, Andrew Lunn wrote:
> > Without the clock being held by a driver, it gets turned off at a bad
> > time causing the SoC to lockup. This is often during reboot.
> > 
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > Tested-by: Stefan Peter <s.peter@mpl.ch>
> > ---
> >  arch/arm/boot/dts/kirkwood.dtsi |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi
> > index 7735cee..110d6cb 100644
> > --- a/arch/arm/boot/dts/kirkwood.dtsi
> > +++ b/arch/arm/boot/dts/kirkwood.dtsi
> > @@ -144,6 +144,7 @@
> >  			compatible = "marvell,orion-ehci";
> >  			reg = <0x50000 0x1000>;
> >  			interrupts = <19>;
> > +			clocks = <&gate_clk 3>;
> >  			status = "okay";
> >  		};
> 
> Hi Andrew,
> 
> Maybe you also want to remove the clock alias workaround from
> kirkwood_legacy_clk_init() ?

Hi Simon

That is not really a fix. It does no harm being there.

We will remove it as a cleanup in 3.9. We can also remove the SDIO
legacy clock as well, since Thomas has patches to convert that driver
to DT.

   Andrew