All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Giuseppe CONDORELLI <giuseppe.condorelli@st.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] libpcre: set BUILD_CFLAGS
Date: Mon, 7 Jan 2013 17:15:36 +0100	[thread overview]
Message-ID: <20130107161536.GE3285@jama> (raw)
In-Reply-To: <1357550207-19933-1-git-send-email-giuseppe.condorelli@st.com>

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

On Mon, Jan 07, 2013 at 10:16:47AM +0100, Giuseppe CONDORELLI wrote:
> Set LINK_SIZE in BUILD_CFLAGS given that the autotools bbclass use it to set
> CFLAG_FOR_BUILD, required for the libpcre build.

CFLAG_FOR_BUILD typo in commit body and comment in recipe and please change 
subject to indicate that you're _changing_  BUILD_CFLAGS and
BUILD_CPPFLAGS value.

> Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli@st.com>
> ---
>  meta/recipes-support/libpcre/libpcre_8.32.bb |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-support/libpcre/libpcre_8.32.bb b/meta/recipes-support/libpcre/libpcre_8.32.bb
> index e434d55..361e9f0 100644
> --- a/meta/recipes-support/libpcre/libpcre_8.32.bb
> +++ b/meta/recipes-support/libpcre/libpcre_8.32.bb
> @@ -34,8 +34,9 @@ EXTRA_OECONF = "\
>      --with-match-limit=10000000 \
>  "
>  
> -BUILD_CPPFLAGS += "-DLINK_SIZE=2"
> -BUILD_CFLAGS =+ "-I${S}/include"
> +# Set LINK_SIZE in BUILD_CFLAGS given that the autotools bbclass use it to
> +# set CFLAG_FOR_BUILD, required for the libpcre build.
> +BUILD_CFLAGS =+ "-DLINK_SIZE=2 -I${S}/include"
>  CFLAGS += "-D_REENTRANT"
>  CXXFLAGS_append_powerpc = " -lstdc++"
>  
> -- 
> 1.7.7.6
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

      reply	other threads:[~2013-01-07 16:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07  9:16 [PATCH] libpcre: set BUILD_CFLAGS Giuseppe CONDORELLI
2013-01-07 16:15 ` Martin Jansa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130107161536.GE3285@jama \
    --to=martin.jansa@gmail.com \
    --cc=giuseppe.condorelli@st.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.