From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Mon, 7 Jan 2013 08:48:45 -0800 Subject: [PATCH 3.9] Driver for 7-segment displays connected over GPIOs In-Reply-To: <1357576928-29133-1-git-send-email-thomas.petazzoni@free-electrons.com> References: <1357576928-29133-1-git-send-email-thomas.petazzoni@free-electrons.com> Message-ID: <20130107164845.GA2911@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jan 07, 2013 at 05:42:05PM +0100, Thomas Petazzoni wrote: > Dear drivers/{char,misc}/ maintainers, > > This patch series implements a simple driver for 7-segment displays > connected over GPIOs through a BCD encoder. The userspace interface of > the driver is very simple: just a "value" file in the sysfs directory > of the device, which can be written to (changes the value shown on the > 7-segment display) and read (gives the current value). If you ever add/remove/modify sysfs files, you have to also do the same for the Documentation/ABI/ files as well, please redo that in this patch series. But, the bigger question is, why is this a kernel driver at all? Can't you do this from userspace today without any new kernel code? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 3.9] Driver for 7-segment displays connected over GPIOs Date: Mon, 7 Jan 2013 08:48:45 -0800 Message-ID: <20130107164845.GA2911@kroah.com> References: <1357576928-29133-1-git-send-email-thomas.petazzoni@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1357576928-29133-1-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Thomas Petazzoni Cc: Lior Amsalem , Andrew Lunn , Jason Cooper , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, Jan 07, 2013 at 05:42:05PM +0100, Thomas Petazzoni wrote: > Dear drivers/{char,misc}/ maintainers, > > This patch series implements a simple driver for 7-segment displays > connected over GPIOs through a BCD encoder. The userspace interface of > the driver is very simple: just a "value" file in the sysfs directory > of the device, which can be written to (changes the value shown on the > 7-segment display) and read (gives the current value). If you ever add/remove/modify sysfs files, you have to also do the same for the Documentation/ABI/ files as well, please redo that in this patch series. But, the bigger question is, why is this a kernel driver at all? Can't you do this from userspace today without any new kernel code? thanks, greg k-h