diff for duplicates of <20130107173557.dadc0a7a.akpm@linux-foundation.org> diff --git a/a/1.txt b/N1/1.txt index aa018e3..3fccc28 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -15,7 +15,7 @@ On Tue, 08 Jan 2013 10:25:35 +0900 Jingoo Han <jg1.han@samsung.com> wrote: > > > struct backlight_device *new_bd; > > > int rc; > > > -> > > + if (name = NULL) { +> > > + if (name == NULL) { > > > + pr_err("backlight name is null\n"); > > > + return ERR_PTR(-EINVAL); > > > + } @@ -35,7 +35,7 @@ On Tue, 08 Jan 2013 10:25:35 +0900 Jingoo Han <jg1.han@samsung.com> wrote: > > Do you mean following? > -> + if (name = NULL) +> + if (name == NULL) > + pr_err("passing name=NULL is a bug"); > + > pr_debug("backlight_device_register: name=%s\n", name); diff --git a/a/content_digest b/N1/content_digest index ba6e9b4..a1ab751 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0003c01cded3f$0f25a3e0$2d70eba0$%han@samsung.com\0" "From\0Andrew Morton <akpm@linux-foundation.org>\0" "Subject\0Re: [PATCH] backlight: check null deference of name when device is registered\0" - "Date\0Tue, 08 Jan 2013 01:35:57 +0000\0" + "Date\0Mon, 7 Jan 2013 17:35:57 -0800\0" "To\0Jingoo Han <jg1.han@samsung.com>\0" "Cc\0'LKML' <linux-kernel@vger.kernel.org>" linux-fbdev@vger.kernel.org @@ -28,7 +28,7 @@ "> > > \tstruct backlight_device *new_bd;\n" "> > > \tint rc;\n" "> > >\n" - "> > > +\tif (name = NULL) {\n" + "> > > +\tif (name == NULL) {\n" "> > > +\t\tpr_err(\"backlight name is null\\n\");\n" "> > > +\t\treturn ERR_PTR(-EINVAL);\n" "> > > +\t}\n" @@ -48,7 +48,7 @@ "> \n" "> Do you mean following?\n" "> \n" - "> +\tif (name = NULL)\n" + "> +\tif (name == NULL)\n" "> +\t\tpr_err(\"passing name=NULL is a bug\");\n" "> +\n" "> \tpr_debug(\"backlight_device_register: name=%s\\n\", name);\n" @@ -56,4 +56,4 @@ "Nope; I'm suggesting we leave the code alone. If someone passes in\n" NULL they will get a nice oops and their bug will then get fixed. -98a81d096b1b51c11b2812f883b2d0bb85bbabc3bf56e4c66d095dfdc0fd1c30 +82844d97a66159a7d9022dcb383ca50b10f7233dc8f2a79a4a8701a4dbf66223
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.