All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: vt6656: Remove ULONG_PTR/DWORD_PTR from driver.
Date: Mon, 7 Jan 2013 11:07:05 -0800	[thread overview]
Message-ID: <20130107190705.GA11344@kroah.com> (raw)
In-Reply-To: <1354137348.2633.3.camel@user64-MCP7A>

On Wed, Nov 28, 2012 at 09:15:48PM +0000, Malcolm Priestley wrote:
> 
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> ---
>  drivers/staging/vt6656/bssdb.c |   89 +++++++++++++++++++---------------------
>  drivers/staging/vt6656/ttype.h |    3 --
>  2 files changed, 42 insertions(+), 50 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/bssdb.c b/drivers/staging/vt6656/bssdb.c
> index 539bc1d..d27469e 100644
> --- a/drivers/staging/vt6656/bssdb.c
> +++ b/drivers/staging/vt6656/bssdb.c
> @@ -355,13 +355,13 @@ BOOL BSSbInsertToBSSList(void *hDeviceContext,
>  			 PBYTE pbyIEs,
>  			 void *pRxPacketContext)
>  {
> -
> -    PSDevice     pDevice = (PSDevice)hDeviceContext;
> -    PSMgmtObject    pMgmt = &(pDevice->sMgmtObj);
> -    PSRxMgmtPacket  pRxPacket = (PSRxMgmtPacket)pRxPacketContext;
> -    PKnownBSS       pBSSList = NULL;
> -    unsigned int            ii;
> -    BOOL            bParsingQuiet = FALSE;
> +	PSDevice pDevice = (PSDevice)hDeviceContext;
> +	PSMgmtObject pMgmt = &pDevice->sMgmtObj;
> +	PSRxMgmtPacket pRxPacket = (PSRxMgmtPacket)pRxPacketContext;
> +	PKnownBSS pBSSList = NULL;
> +	unsigned int ii;
> +	int bParsingQuiet = FALSE;
> +	u32 uLen;

This patch also adjusts formatting, making it hard to see that you
really changed the BOOL variable here, which is not what you said the
patch was doing :(

Please redo this patch, and _only_ make the changes you say you are
making.

thanks,

greg k-h

      reply	other threads:[~2013-01-07 19:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28 21:15 [PATCH 2/3] staging: vt6656: Remove ULONG_PTR/DWORD_PTR from driver Malcolm Priestley
2013-01-07 19:07 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130107190705.GA11344@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tvboxspy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.