From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 3/9] Thermal: Add APIs to bind cdev to new zone structure Date: Mon, 7 Jan 2013 11:26:02 -0800 Message-ID: <20130107192602.GD4465@kroah.com> References: <1357542806-20449-1-git-send-email-durgadoss.r@intel.com> <1357542806-20449-4-git-send-email-durgadoss.r@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:38548 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755150Ab3AGT0G (ORCPT ); Mon, 7 Jan 2013 14:26:06 -0500 Received: by mail-pa0-f46.google.com with SMTP id bh2so10854917pad.5 for ; Mon, 07 Jan 2013 11:26:06 -0800 (PST) Content-Disposition: inline In-Reply-To: <1357542806-20449-4-git-send-email-durgadoss.r@intel.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Durgadoss R Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, eduardo.valentin@ti.com, hongbo.zhang@linaro.org, wni@nvidia.com On Mon, Jan 07, 2013 at 12:43:20PM +0530, Durgadoss R wrote: > +struct thermal_cooling_device *get_cdev_by_name(const char *name) > +{ > + struct thermal_cooling_device *pos; > + struct thermal_cooling_device *cdev = NULL; > + > + mutex_lock(&cdev_list_lock); > + for_each_cdev(pos) { > + if (!strnicmp(pos->type, name, THERMAL_NAME_LENGTH)) { > + cdev = pos; > + break; > + } > + } > + mutex_unlock(&cdev_list_lock); > + return cdev; > +} > +EXPORT_SYMBOL(get_cdev_by_name); EXPORT_SYMBOL_GPL? You also forgot to increment the reference count, which is required for all reference counted objects. thanks, greg k-h