From: "Eric Bénard" <eric@eukrea.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] libnl: fix compilation on hosts without lex
Date: Mon, 7 Jan 2013 21:48:42 +0100 [thread overview]
Message-ID: <20130107214842.428342a9@e6520eb> (raw)
In-Reply-To: <CAP9ODKqOsQMrRDtw+uRgCb4Twr60wC+pbjB9m4_MrPrvF15eyg@mail.gmail.com>
Hi Otavio,
Le Mon, 7 Jan 2013 15:59:24 -0200,
Otavio Salvador <otavio@ossystems.com.br> a écrit :
> On Mon, Jan 7, 2013 at 2:43 PM, Eric Bénard <eric@eukrea.com> wrote:
> > * libnl's makefiles are calling $(LEX) but only define $(FLEX), thus
> > compilation on a host which doesn't have lex fails with :
> > | lex --header-file=route/cls/ematch_grammar.h -o route/cls/ematch_grammar.c route/cls/ematch_grammar.l
> > | make[1]: lex: Command not found
> > | make[1]: *** [route/cls/ematch_grammar.c] Error 127
> >
> > * this patch fix this by setting LEX variable to flex tool
> >
> > Signed-off-by: Eric Bénard <eric@eukrea.com>
>
> I have prepared a patch for this issue but I did patch the Makefile.am
> to use $(FLEX) as this is the fix commited in upstream 3.2.17. If you
> do not object, I'd like to propose mine patch for review as it is more
> in line with upstream fix.
>
as the end result is the same, the maintainer now has the choice ;-)
Eric
prev parent reply other threads:[~2013-01-07 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 16:43 [PATCH] libnl: fix compilation on hosts without lex Eric Bénard
2013-01-07 17:59 ` Otavio Salvador
2013-01-07 20:48 ` Eric Bénard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107214842.428342a9@e6520eb \
--to=eric@eukrea.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.