All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Vinod Koul <vinod.koul@intel.com>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: linux-next: comment in commit in the slave-dma tree (dmaengine: dw_dmac: Enhance device tree support)
Date: Mon, 7 Jan 2013 14:43:08 -0800	[thread overview]
Message-ID: <20130107224308.GB27477@kroah.com> (raw)
In-Reply-To: <20130108093557.8a29d4a04b95702fc59790ff@canb.auug.org.au>

On Tue, Jan 08, 2013 at 09:35:57AM +1100, Stephen Rothwell wrote:
> Hi Vinod,
> 
> In commit 548860697046 ("dmaengine: dw_dmac: Enhance device tree
> support") (which was changed since yesterday :-(), an instance of
> __devinit has been added.  We are in the process of making CONFIG_HOTPLUG
> always true, and since commit 78d86c213f28 ("init.h: Remove __dev*
> sections from the kernel") (included in v3.7), __devinit does nothing.
> Please do not add any more.

That brings up something I wanted to ask you.

I'd like to send a patch to Linus to just delete __devinit and friends
entirely from init.h, but that will break the linux-next tree from
building in places (like this one, and in a few others.)

Is that ok?  That should finally get everyone's attention and keep them
from the cargo-cult programming mode of using these attributes :)

thanks,

greg k-h

  reply	other threads:[~2013-01-07 22:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 22:35 linux-next: comment in commit in the slave-dma tree (dmaengine: dw_dmac: Enhance device tree support) Stephen Rothwell
2013-01-07 22:43 ` Greg Kroah-Hartman [this message]
2013-01-07 22:57   ` Stephen Rothwell
2013-01-08  8:19   ` Vinod Koul
2013-01-08  4:49 ` Viresh Kumar
2013-01-08  8:20   ` Vinod Koul
2013-01-08  8:17 ` Vinod Koul
2013-01-08 11:36   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130107224308.GB27477@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=vinod.koul@intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.