From: Fengguang Wu <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kent Overstreet <koverstreet@google.com>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
LKML <linux-kernel@vger.kernel.org>
Subject: [avr32] [next:akpm 212/227] lib/percpu-refcount.c:57: warning: value computed is not used
Date: Tue, 8 Jan 2013 10:26:14 +0800 [thread overview]
Message-ID: <20130108022614.GD5368@localhost> (raw)
In-Reply-To: <20130107122052.049f8867.akpm@linux-foundation.org>
[CC avr32 maintainers]
On Mon, Jan 07, 2013 at 12:20:52PM -0800, Andrew Morton wrote:
> On Mon, 07 Jan 2013 12:45:36 +0800
> kbuild test robot <fengguang.wu@intel.com> wrote:
>
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
> > head: e862d51dae9808e394a118ca1692f09bf0751aba
> > commit: 6311ac08e93b12f1367da092b413dd2434be45f5 [212/227] generic dynamic per cpu refcounting
> > config: make ARCH=avr32 atngw100_defconfig
> >
> > All warnings:
> >
> > lib/percpu-refcount.c: In function 'percpu_ref_init':
> > lib/percpu-refcount.c:22: error: 'jiffies' undeclared (first use in this function)
> > lib/percpu-refcount.c:22: error: (Each undeclared identifier is reported only once
> > lib/percpu-refcount.c:22: error: for each function it appears in.)
> > lib/percpu-refcount.c: In function 'percpu_ref_alloc':
> > lib/percpu-refcount.c:36: error: 'jiffies' undeclared (first use in this function)
> > lib/percpu-refcount.c:41: error: 'HZ' undeclared (first use in this function)
> > lib/percpu-refcount.c:57: warning: value computed is not used
> >
>
> Confused.
> http://ozlabs.org/~akpm/mmotm/broken-out/generic-dynamic-per-cpu-refcounting-fix.patch
> added the jiffies.h include.
Oh that patch's linux-next commit is 18bc58821de88e5621cfdaac78c814ea479accab
and goes _after_ the current commit 6311ac08e93b12f1367da092b413dd2434be45f5.
So linux-next HEAD no longer has the build errors, however I still got these
warnings:
CC lib/percpu-refcount.o
In file included from /c/wfg/linux/include/uapi/linux/param.h:4,
from /c/wfg/linux/include/linux/timex.h:63,
from /c/wfg/linux/include/linux/jiffies.h:8,
from /c/wfg/linux/lib/percpu-refcount.c:4:
==> /c/wfg/linux/arch/avr32/include/asm/param.h:6:1: warning: "HZ" redefined
That's a trivial avr32 problem.
In file included from /c/wfg/linux/arch/avr32/include/asm/param.h:4,
from /c/wfg/linux/include/uapi/linux/param.h:4,
from /c/wfg/linux/include/linux/timex.h:63,
from /c/wfg/linux/include/linux/jiffies.h:8,
from /c/wfg/linux/lib/percpu-refcount.c:4:
/c/wfg/linux/arch/avr32/include/uapi/asm/param.h:6:1: warning: this is the location of the previous definition
/c/wfg/linux/lib/percpu-refcount.c: In function 'percpu_ref_alloc':
==> /c/wfg/linux/lib/percpu-refcount.c:58: warning: value computed is not used
That's perhaps related to how cmpxchg() is expanded in avr32.
/c/wfg/linux/lib/percpu-refcount.c: In function 'percpu_ref_kill':
==> /c/wfg/linux/lib/percpu-refcount.c:114: warning: 'new' may be used uninitialized in this function
Should be a false warning. The code looks fine.
Thanks,
Fengguang
parent reply other threads:[~2013-01-08 2:26 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20130107122052.049f8867.akpm@linux-foundation.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108022614.GD5368@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=egtvedt@samfundet.no \
--cc=hskinnemoen@gmail.com \
--cc=koverstreet@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.