From: Marek Vasut <marex@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: cjb@laptop.org, linux-mmc@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] mmc: mxs-mmc: Fix warning due to incorrect type
Date: Tue, 8 Jan 2013 07:57:29 +0100 [thread overview]
Message-ID: <201301080757.29584.marex@denx.de> (raw)
In-Reply-To: <1357605755-8872-1-git-send-email-festevam@gmail.com>
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Fixes the following warning when building with W=1 option:
>
> drivers/mmc/host/mxs-mmc.c: In function 'mxs_mmc_adtc':
> drivers/mmc/host/mxs-mmc.c:401:2: warning: comparison between signed and
> unsigned integer expressions [-Wsign-compare]
>
> The warning happens because 'i' is used in 'for_each_sg(sgl, sg, sg_len,
> i)' and should be made unsigned.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Nice
Acked-by: Marek Vasut <marex@denx.de>
> ---
> drivers/mmc/host/mxs-mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
> index 206fe49..eb33cb1 100644
> --- a/drivers/mmc/host/mxs-mmc.c
> +++ b/drivers/mmc/host/mxs-mmc.c
> @@ -354,7 +354,7 @@ static void mxs_mmc_adtc(struct mxs_mmc_host *host)
> struct dma_async_tx_descriptor *desc;
> struct scatterlist *sgl = data->sg, *sg;
> unsigned int sg_len = data->sg_len;
> - int i;
> + unsigned int i;
>
> unsigned short dma_data_dir, timeout;
> enum dma_transfer_direction slave_dirn;
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-01-08 6:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 0:42 [PATCH] mmc: mxs-mmc: Fix warning due to incorrect type Fabio Estevam
2013-01-08 6:57 ` Marek Vasut [this message]
2013-01-28 20:48 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301080757.29584.marex@denx.de \
--to=marex@denx.de \
--cc=cjb@laptop.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.