From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: Axel Lin <axel.lin@ingics.com>, "Girdwood, Liam" <lrg@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFT] regulator: lp8788-ldo: Use ldo->en_pin to check if regulator is enabled by external pin
Date: Tue, 8 Jan 2013 10:43:21 +0000 [thread overview]
Message-ID: <20130108104321.GJ4544@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F69E11935@DQHE02.ent.ti.com>
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On Mon, Jan 07, 2013 at 11:23:26PM +0000, Kim, Milo wrote:
> > Applied, thanks. However we should be converting the driver to use the
> > core support for this - the GPIO can just be given to the core in the
> > regulator config which should handle everything transparently.
> I have a question.
> Do you mean the dependency of CONFIG_GENERIC_GPIO in this driver?
No. I mean you should use the regulator API core functionality for
managing GPIO enables instead of open coding it.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-01-08 10:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-05 7:33 [PATCH RFT] regulator: lp8788-ldo: Use ldo->en_pin to check if regulator is enabled by external pin Axel Lin
2013-01-07 1:17 ` Kim, Milo
2013-01-07 11:08 ` Mark Brown
2013-01-07 23:23 ` Kim, Milo
2013-01-08 10:43 ` Mark Brown [this message]
[not found] ` <CAFRkauBBHtjR+GYogpVPxBwGnoJD2==MUaqhZ6KOC7TJE4SpAA@mail.gmail.com>
2013-01-08 10:43 ` Mark Brown
2013-01-09 2:34 ` Kim, Milo
2013-01-09 15:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108104321.GJ4544@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Milo.Kim@ti.com \
--cc=axel.lin@ingics.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.