From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>,
Inderpal Singh <inderpal.singh@linaro.org>,
Amit Daniel Kachhap <amit.daniel@samsung.com>,
Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: s5m8767: Remove max_vol parameter from s5m8767_convert_voltage_to_sel
Date: Tue, 8 Jan 2013 11:12:45 +0000 [thread overview]
Message-ID: <20130108111244.GO4544@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1356745130.8271.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
On Sat, Dec 29, 2012 at 09:38:50AM +0800, Axel Lin wrote:
> It looks pointless to pass max_vol to s5m8767_convert_voltage_to_sel().
> Compare selected voltage to desc->max is enough to ensure selected voltage
> is in supported range.
This doesn't apply against -rc2, can you please regenerate?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-01-08 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-29 1:38 [PATCH] regulator: s5m8767: Remove max_vol parameter from s5m8767_convert_voltage_to_sel Axel Lin
2013-01-08 11:12 ` Mark Brown [this message]
2013-01-17 7:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108111244.GO4544@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=amit.daniel@samsung.com \
--cc=axel.lin@ingics.com \
--cc=inderpal.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.