From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: masa-korg@dsn.okisemi.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Tomoya MORINAGA <tomoya.rohm@gmail.com>
Subject: Re: add Packet hub driver for Topcliff Platform controller hub
Date: Tue, 8 Jan 2013 14:48:46 +0300 [thread overview]
Message-ID: <20130108114846.GQ7302@mwanda> (raw)
In-Reply-To: <201301081049.15118.arnd@arndb.de>
On Tue, Jan 08, 2013 at 10:49:14AM +0000, Arnd Bergmann wrote:
> On Monday 07 January 2013, Dan Carpenter wrote:
> > Sorry my question is about an old patch. Smatch complains because we
> > only pass a PAGE_SIZE buffer to sysfs files so the test for
> > "if (count > PCH_PHUB_OROM_SIZE) {" makes it think we are overflowing.
> > In fact, count is never more than 4096 so there is no overflow, but I
> > also think that it means only the first 4096 bytes of the firmware gets
> > updated.
>
> I think it works correctly as long as user space keeps writing into the
> bin file when getting short write return (4096 bytes).
>
Ah. Ok. I misunderstood. I've looked through it again and you're
right.
Sorry for the noise.
regards,
dan carpenter
next prev parent reply other threads:[~2013-01-08 11:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 9:02 add Packet hub driver for Topcliff Platform controller hub Dan Carpenter
2013-01-08 10:30 ` Tomoya MORINAGA
2013-01-08 11:38 ` Dan Carpenter
2013-01-08 10:49 ` Arnd Bergmann
2013-01-08 11:48 ` Dan Carpenter [this message]
2013-01-08 11:56 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108114846.GQ7302@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masa-korg@dsn.okisemi.com \
--cc=tomoya.rohm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.