From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe.Lawrence@stratus.com
Cc: linux-raid@vger.kernel.org
Subject: re: md: raid1,10: Handle REQ_WRITE_SAME flag in write bios
Date: Tue, 8 Jan 2013 16:44:15 +0300 [thread overview]
Message-ID: <20130108134415.GA840@elgon.mountain> (raw)
Hello Joe Lawrence,
This is a semi-automatic email about new static checker warnings.
The patch aa992f57bd76: "md: raid1,10: Handle REQ_WRITE_SAME flag in
write bios" from Dec 14, 2012, leads to the following Smatch
complaint:
drivers/md/raid10.c:3630 run()
error: we previously assumed 'mddev->queue' could be null (see line 3619)
drivers/md/raid10.c
3618 chunk_size = mddev->chunk_sectors << 9;
3619 if (mddev->queue) {
^^^^^^^^^^^^
Old check.
3620 blk_queue_max_discard_sectors(mddev->queue,
3621 mddev->chunk_sectors);
3622 blk_queue_io_min(mddev->queue, chunk_size);
3623 if (conf->geo.raid_disks % conf->geo.near_copies)
3624 blk_queue_io_opt(mddev->queue, chunk_size * conf->geo.raid_disks);
3625 else
3626 blk_queue_io_opt(mddev->queue, chunk_size *
3627 (conf->geo.raid_disks / conf->geo.near_copies));
3628 }
3629
3630 blk_queue_max_write_same_sectors(mddev->queue, mddev->chunk_sectors);
^^^^^^^^^^^^
New dereference.
3631 rdev_for_each(rdev, mddev) {
3632 long long diff;
regards,
dan carpenter
next reply other threads:[~2013-01-08 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 13:44 Dan Carpenter [this message]
2013-01-09 4:11 ` md: raid1,10: Handle REQ_WRITE_SAME flag in write bios Joe Lawrence
-- strict thread matches above, loose matches on Subject: below --
2013-01-08 13:23 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108134415.GA840@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=Joe.Lawrence@stratus.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.