From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TscAs-00008Y-L9 for qemu-devel@nongnu.org; Tue, 08 Jan 2013 11:37:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TscAq-0006As-OB for qemu-devel@nongnu.org; Tue, 08 Jan 2013 11:37:14 -0500 Received: from smtp4.mundo-r.com ([212.51.32.151]:60470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TscAq-0006AY-HJ for qemu-devel@nongnu.org; Tue, 08 Jan 2013 11:37:12 -0500 Date: Tue, 8 Jan 2013 17:37:09 +0100 From: Alberto Garcia Message-ID: <20130108163709.GA29828@igalia.com> References: <4773138dce3a8e61f90ebc20837ff4a283137eb3.1357607262.git.agarcia@igalia.com> <50EC256C.5060607@suse.de> <20130108155754.GA25155@igalia.com> <50EC47CB.7070705@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <50EC47CB.7070705@suse.de> Subject: Re: [Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 IndustryPack emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Blue Swirl , Paolo Bonzini , Anthony Liguori , qemu-devel@nongnu.org On Tue, Jan 08, 2013 at 05:22:35PM +0100, Andreas Färber wrote: > > Tell me if there's anything else I should change, else I can post > > the new patches. > > Haven't looked at the latest 2/2 patch yet, same might apply there. > Otherwise no issues spotted in 1/2. Yes, I updated both patches. Shall I resend them now or wait for more comments? > >> Another thing to check (could be a follow-up) is whether the > >> initfn can be split into instance_init (e.g., pci_set_*?) and > >> initfn. There's only PCI code in the init function, does it make sense to split it? And am I actually supposed to write in the PCI configuration space from instance_init()? Berto