From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Goyal Subject: Re: [PATCH 17/24] blkcg: implement blkcg_policy->on/offline_pd_fn() and blkcg_gq->online Date: Tue, 8 Jan 2013 11:58:53 -0500 Message-ID: <20130108165853.GH29635@redhat.com> References: <1356726946-26037-1-git-send-email-tj@kernel.org> <1356726946-26037-18-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1356726946-26037-18-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, ctalbott-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, rni-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Fri, Dec 28, 2012 at 12:35:39PM -0800, Tejun Heo wrote: > Add two blkcg_policy methods, ->online_pd_fn() and ->offline_pd_fn(), > which are invoked as the policy_data gets activated and deactivated > while holding both blkcg and q locks. > > Also, add blkcg_gq->online bool, which is set and cleared as the > blkcg_gq gets activated and deactivated. This flag also is toggled > while holding both blkcg and q locks. > > These will be used to implement hierarchical stats. > > Signed-off-by: Tejun Heo > --- Acked-by: Vivek Goyal Vivek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756730Ab3AHQ7K (ORCPT ); Tue, 8 Jan 2013 11:59:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1034 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753514Ab3AHQ7I (ORCPT ); Tue, 8 Jan 2013 11:59:08 -0500 Date: Tue, 8 Jan 2013 11:58:53 -0500 From: Vivek Goyal To: Tejun Heo Cc: lizefan@huawei.com, axboe@kernel.dk, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, ctalbott@google.com, rni@google.com Subject: Re: [PATCH 17/24] blkcg: implement blkcg_policy->on/offline_pd_fn() and blkcg_gq->online Message-ID: <20130108165853.GH29635@redhat.com> References: <1356726946-26037-1-git-send-email-tj@kernel.org> <1356726946-26037-18-git-send-email-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1356726946-26037-18-git-send-email-tj@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 28, 2012 at 12:35:39PM -0800, Tejun Heo wrote: > Add two blkcg_policy methods, ->online_pd_fn() and ->offline_pd_fn(), > which are invoked as the policy_data gets activated and deactivated > while holding both blkcg and q locks. > > Also, add blkcg_gq->online bool, which is set and cleared as the > blkcg_gq gets activated and deactivated. This flag also is toggled > while holding both blkcg and q locks. > > These will be used to implement hierarchical stats. > > Signed-off-by: Tejun Heo > --- Acked-by: Vivek Goyal Vivek