From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tsjy1-0000dm-0l for qemu-devel@nongnu.org; Tue, 08 Jan 2013 19:56:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tsjxz-0008WA-Ur for qemu-devel@nongnu.org; Tue, 08 Jan 2013 19:56:28 -0500 Received: from smtp4.mundo-r.com ([212.51.32.151]:64882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tsjxz-0008W5-OI for qemu-devel@nongnu.org; Tue, 08 Jan 2013 19:56:27 -0500 Date: Wed, 9 Jan 2013 01:56:24 +0100 From: Alberto Garcia Message-ID: <20130109005624.GA4199@igalia.com> References: <4a5728bd52fbd15616ba7a20ffb3e1a90be2cc74.1357607262.git.agarcia@igalia.com> <50EC60B9.60304@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <50EC60B9.60304@suse.de> Subject: Re: [Qemu-devel] [PATCH v4 2/2] Add GE IP-Octal 232 IndustryPack emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Blue Swirl , Paolo Bonzini , Anthony Liguori , qemu-devel@nongnu.org On Tue, Jan 08, 2013 at 07:08:57PM +0100, Andreas Färber wrote: > On my suggestion you changed the type name from "ipoctal" to > "ipoctal232" - the file name should probably then be updated, too. > For the function prefixes inside the file it shouldn't matter as > long as they're consistent. The reason why I decided to stay with 'ipoctal' everywhere except in the visible fields (TypeInfo.name, and VMStateDescription.name) is because the other devices of the IP-Octal family are almost identical from the emulation point of view, so if a new one ever gets emulated most code will be shared. I'm not sure if it makes sense to rename anything else in this situation... > > +struct IPOctalState { > > + IPackDevice dev; > > By convention: > > IPackDevice parent_obj; I only see that in a few places, is that a recent thing? Most devices that I see use 'dev' or similar to refer to their parent objects. > But if, as brought up at LinuxCon, you may want to add qtest cases > it may be helpful to move some of the constants above to their > own header file ipoctal232_regs.h as done for RTC or pending for > TMP105. That could be split out in a later step though, once PCI > libqos is available. Yeah, I'm not sure if I'll have much time to work on this in the short term... > P.S. No need to CC avi@redhat.com any longer, you may have noticed. > ;) Yes, I did :) Berto