From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2] staging: sb105x: clean up interface type test
Date: Wed, 09 Jan 2013 07:44:25 +0000 [thread overview]
Message-ID: <20130109074425.GU7247@mwanda> (raw)
In-Reply-To: <20130109071214.GC2454@elgon.mountain>
On Wed, Jan 09, 2013 at 10:12:14AM +0300, Dan Carpenter wrote:
> IIR_RS232 is zero so "if (IIR_RS232 = (b_ret & IIR_RS232))" is always
> true so RS232 was always chosen by default. The test should be
> "if (0 = (b_ret & 0x30)) { ". The other tests should also be in that
> format.
>
> My patch doesn't change how the code works. I've left the RS232 as the
> default and cleaned up the other checks.
>
Sorry that was a bad change log. My patch actually does change how
the code works... If 0x30 is set then it now defaults to RS232
instead of RS485.
But I think it's the right thing to do.
regards,
dan carpenter
next prev parent reply other threads:[~2013-01-09 7:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 7:12 [patch 2/2] staging: sb105x: clean up interface type test Dan Carpenter
2013-01-09 7:44 ` Dan Carpenter [this message]
2013-01-09 13:27 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109074425.GU7247@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.