All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: Johan Danielsson <joda@kth.se>, linux-wireless@vger.kernel.org
Subject: Re: mac80211 and RX of A-MPDU with missing back agreement
Date: Wed, 9 Jan 2013 11:54:38 +0100	[thread overview]
Message-ID: <20130109105437.GB13513@redhat.com> (raw)
In-Reply-To: <201301090038.01984.chunkeey@googlemail.com>

Hi

On Wed, Jan 09, 2013 at 12:38:01AM +0100, Christian Lamparter wrote:
> Yes, this sounds wrong. Was there a historic reason why RX_STOP was put before
> DELBA? I've traced the code back to Intel's initial A-MPDU RX contribution:
> 
> commit 07db218396650933abff3c5c1ad1e2a6e0cfedeb
> Author: Ron Rindjunsky <ron.rindjunsky@intel.com>
> Date:   Tue Dec 25 17:00:33 2007 +0200
> 
>     mac80211: A-MPDU Rx adding basic functionality
> 
> 
> Stanislaw, do you know if iwlegacy needs AGG_RX_STOP before it can sent out
> the DELBA [Maybe something about flushing an FW internal RX reorder buffer,
> or anything]?

I think not, AGG_RX_STOP disable in firmware (ht-immediate) BA response,
when receive AMPDU (for particular station/tid). So ordering: DELBA, then
AGG_RX_STOP should be fine for iwlegacy and iwlwifi.

Thanks
Stanislaw


  parent reply	other threads:[~2013-01-09 10:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 10:32 mac80211 and RX of A-MPDU with missing back agreement Johan Danielsson
2013-01-07 19:53 ` Christian Lamparter
2013-01-08 10:39   ` Johan Danielsson
2013-01-08 16:15     ` Christian Lamparter
2013-01-08 21:47       ` Johan Danielsson
2013-01-08 23:38         ` Christian Lamparter
2013-01-09 10:05           ` Johan Danielsson
2013-01-09 17:43             ` Christian Lamparter
2013-01-09 18:32               ` Christian Lamparter
2013-01-09 10:54           ` Stanislaw Gruszka [this message]
2013-01-09 12:02           ` Johannes Berg
2013-01-09 13:46             ` Christian Lamparter
2013-01-09 13:54               ` Johannes Berg
2013-01-09 18:05                 ` Christian Lamparter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130109105437.GB13513@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=chunkeey@googlemail.com \
    --cc=joda@kth.se \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.