Re: [PATCH 7/8] Bluetooth: Fix checking for exact values of boolean mgmt parameters

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Lizardo,

On Wed, Jan 09, 2013, Anderson Lizardo wrote:
> Hi Johan,
> 
> On Wed, Jan 9, 2013 at 9:29 AM, Johan Hedberg <johan.hedberg@gmail.com> wrote:
> > @@ -1219,6 +1247,10 @@ static int set_le(struct sock *sk, struct hci_dev *hdev, void *data, u16 len)
> >                 return cmd_status(sk, hdev->id, MGMT_OP_SET_LE,
> >                                   MGMT_STATUS_NOT_SUPPORTED);
> >
> > +       if (cp->val != 0x00 && cp->val != 0x01)
> > +               return cmd_status(sk, hdev->id, MGMT_OP_SET_SSP,
> > +                                 MGMT_STATUS_INVALID_PARAMS);
> > +
> 
> I think you meant "MGMT_OP_SET_LE" here.

Good catch. A copy-paste mistake I should have caught.

> Can mgmt-tester be modified to check for this as well?

Yes, I don't think it has any set_le test cases yet. Patches are
welcome!

Johan