From: Vinod Koul <vinod.koul@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.jf.intel.com>,
linux-kernel@vger.kernel.org,
spear-devel <spear-devel@list.st.com>
Subject: Re: [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function
Date: Wed, 9 Jan 2013 07:10:01 -0800 [thread overview]
Message-ID: <20130109151001.GR19691@intel.com> (raw)
In-Reply-To: <CAHp75VdWWy7V=PQ2EfXrixX2==yDiakga=tA=jV9bzRrqqzZhw@mail.gmail.com>
On Wed, Jan 09, 2013 at 04:58:02PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 9, 2013 at 4:19 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > n 9 January 2013 19:20, Vinod Koul <vinod.koul@intel.com> wrote:
> >>> +static inline bool is_slave_xfer(enum dma_transfer_direction direction)
> >>> +{
> >>> + return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM);
> >>> +}
> >> After reading the subsequent patch I understand what is intent here. Perhaps
> >> is_slave_dirn() would have been a beter one...
> >
> > dirn isn't readable, it took me some time to understand the intent...
> > Either have xfer or direction :)
>
> Agree with Viresh. I might rename it to is_slave_direction if you want to.
direction sounds fine too.
--
~Vinod
next prev parent reply other threads:[~2013-01-09 15:34 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 12:54 dw_dmac patches Andy Shevchenko
2013-01-08 15:54 ` Vinod Koul
2013-01-09 8:16 ` [resend][PATCH 00/16] dw_dmac related patchset Andy Shevchenko
2013-01-09 8:17 ` [resend][PATCH 01/16] dw_dmac: call .probe after we have a device in place Andy Shevchenko
2013-01-09 13:47 ` Vinod Koul
2013-01-09 14:56 ` Andy Shevchenko
2013-01-09 15:38 ` Vinod Koul
2013-01-09 18:04 ` Mika Westerberg
2013-01-12 12:28 ` Vinod Koul
2013-01-10 8:34 ` Viresh Kumar
2013-01-12 12:30 ` Vinod Koul
2013-01-09 8:17 ` [resend][PATCH 02/16] dw_dmac: absence of pdata isn't critical when autocfg is set Andy Shevchenko
2013-01-09 8:17 ` [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function Andy Shevchenko
2013-01-09 13:50 ` Vinod Koul
2013-01-09 14:19 ` Viresh Kumar
2013-01-09 14:58 ` Andy Shevchenko
2013-01-09 15:10 ` Vinod Koul [this message]
2013-01-09 15:51 ` Andy Shevchenko
2013-01-09 8:17 ` [resend][PATCH 04/16] dma: at_hdmac: check direction properly for cyclic transfers Andy Shevchenko
2013-01-09 8:17 ` [resend][PATCH 05/16] dma: dw_dmac: check direction properly in dw_dma_cyclic_prep Andy Shevchenko
2013-01-09 8:17 ` [resend][PATCH 06/16] dma: ep93xx_dma: reuse is_slave_xfer helper Andy Shevchenko
2013-01-09 8:17 ` [resend][PATCH 07/16] dma: ipu_idmac: " Andy Shevchenko
2013-01-09 8:17 ` [resend][PATCH 08/16] dma: ste_dma40: " Andy Shevchenko
2013-01-09 8:17 ` [resend][PATCH 09/16] dw_dmac: store direction in the custom channel structure Andy Shevchenko
2013-01-09 8:17 ` [resend][PATCH 10/16] dw_dmac: make usage of dw_dma_slave optional Andy Shevchenko
2013-01-09 8:17 ` [resend][PATCH 11/16] dw_dmac: backlink to dw_dma in dw_dma_chan is superfluous Andy Shevchenko
2013-01-09 14:24 ` Vinod Koul
2013-01-09 15:02 ` Andy Shevchenko
2013-01-09 15:11 ` Vinod Koul
2013-01-09 8:17 ` [resend][PATCH 12/16] dw_dmac: check for mapping errors Andy Shevchenko
2013-01-09 8:17 ` [resend][PATCH 13/16] dw_dmac: remove redundant check Andy Shevchenko
2013-01-09 8:17 ` [resend][PATCH 14/16] dw_dmac: update tx_node_active in dwc_do_single_block Andy Shevchenko
2013-01-09 8:17 ` [resend][PATCH 15/16] dma: dw_dmac: add dwc_chan_pause and dwc_chan_resume Andy Shevchenko
2013-01-09 8:17 ` [resend][PATCH 16/16] dma: dw_dmac: clear suspend bit during termination Andy Shevchenko
2013-01-09 14:18 ` Vinod Koul
2013-01-09 15:07 ` Andy Shevchenko
2013-01-09 15:44 ` [resend][PATCH 00/16] dw_dmac related patchset Vinod Koul
2013-01-10 8:28 ` Andy Shevchenko
2013-01-09 11:26 ` dw_dmac patches Andy Shevchenko
2013-01-11 12:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109151001.GR19691@intel.com \
--to=vinod.koul@intel.com \
--cc=andriy.shevchenko@linux.jf.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.