From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 7/9] Thermal: Make PER_ZONE values configurable Date: Wed, 9 Jan 2013 09:00:23 -0800 Message-ID: <20130109170023.GA7068@kroah.com> References: <1357542806-20449-1-git-send-email-durgadoss.r@intel.com> <1357542806-20449-8-git-send-email-durgadoss.r@intel.com> <20130107192414.GC4465@kroah.com> <4D68720C2E767A4AA6A8796D42C8EB59257F01@BGSMSX101.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4D68720C2E767A4AA6A8796D42C8EB59257F01@BGSMSX101.gar.corp.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: "R, Durgadoss" Cc: "Zhang, Rui" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "eduardo.valentin@ti.com" , "hongbo.zhang@linaro.org" , "wni@nvidia.com" List-Id: linux-pm@vger.kernel.org On Wed, Jan 09, 2013 at 09:12:29AM +0000, R, Durgadoss wrote: > Hi Greg, > > > -----Original Message----- > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > Sent: Tuesday, January 08, 2013 12:54 AM > > To: R, Durgadoss > > Cc: Zhang, Rui; linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; > > eduardo.valentin@ti.com; hongbo.zhang@linaro.org; wni@nvidia.com > > Subject: Re: [PATCH 7/9] Thermal: Make PER_ZONE values configurable > > > > On Mon, Jan 07, 2013 at 12:43:24PM +0530, Durgadoss R wrote: > > > This patch makes MAX_SENSORS_PER_ZONE and > > > MAX_CDEVS_PER_ZONE values configurable. The > > > default value is 1, and range is 1-12. > > > > Why would we ever want to change this? Why make this configurable at > > all, how is a distro supposed to set this value? > > > > Shouldn't it be specified from the driver itself? > > These are platform level parameters, that can differ for various platforms. > (Mostly due to board design and thermistor layouts). Stand-alone thermal > sensor drivers are not (need not be) aware of these values. Ok, and how does anyone know how to set them properly? > That's why these values are made configurable. Pushing work onto other people, without telling them what they need to do, isn't nice. Please, either make it auto-configurable, or don't make it configurable at all. As it is, this is useless for a distro, or any "normal" user, right? If these are platform specific things, shouldn't they be defined in the platform data for the hardware? thanks, greg k-h