From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] Adding media-ctl as a package
Date: Wed, 9 Jan 2013 17:02:39 +0100 [thread overview]
Message-ID: <20130109170239.56a4e727@skate> (raw)
In-Reply-To: <1357734594-8211-2-git-send-email-kpa_info@yahoo.fr>
Dear kpa_info at yahoo.fr,
On Wed, 9 Jan 2013 13:29:54 +0100, kpa_info at yahoo.fr wrote:
> +config BR2_PACKAGE_MEDIA_CTL
> + bool "media-ctl"
> + help
> + Media controller control application
One empty newline + upstream URL of the project (even if it's just a
http link to the Git repository). And also the description seems a bit
short, since it does not only contains an application, but also a
library, no?
> diff --git a/package/media-ctl/media-ctl.mk
> b/package/media-ctl/media-ctl.mk new file mode 100644
> index 0000000..3c35278
> --- /dev/null
> +++ b/package/media-ctl/media-ctl.mk
> @@ -0,0 +1,18 @@
> +#############################################################
> +#
> +# media-ctl
> +#
> +#############################################################
> +
> +MEDIA_CTL_VERSION = ac40b79f002a2315f909548614ccd2d408da25b7
> +MEDIA_CTL_SITE = git://git.ideasonboard.org/media-ctl.git
> +MEDIA_CTL_INSTALL_STAGING = YES
> +MEDIA_CTL_LICENSE = GPLv2
The license is LGPLv2.1+.
> +MEDIA_CTL_LICENSE_FILES = COPYING.LIB
> +
> +MEDIA_CTL_AUTORECONF = YES
> +MEDIA_CTL_AUTORECONF_OPT = --install
Are you sure this AUTORECONF_OPT is needed? If so, then please add a
comment before this line that explains why.
> +MEDIA_CTL_CONF_OPT = --with-kernel-headers=$(STAGING_DIR)/usr/include
> +MEDIA_CTL_DEPENDENCIES = host-pkgconf
> +
> +$(eval $(autotools-package))
Otherwise, looks good, thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-01-09 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 12:29 [Buildroot] [PATCH 1/2] Adding yavta (Yet Another V4L2 Test Application) as a package kpa_info at yahoo.fr
2013-01-09 12:29 ` [Buildroot] [PATCH 2/2] Adding media-ctl " kpa_info at yahoo.fr
2013-01-09 16:02 ` Thomas Petazzoni [this message]
2013-01-10 10:24 ` Patrick
2013-01-09 15:59 ` [Buildroot] [PATCH 1/2] Adding yavta (Yet Another V4L2 Test Application) " Thomas Petazzoni
2013-01-10 10:21 ` Patrick
2013-01-10 10:28 ` Thomas Petazzoni
2013-01-10 10:43 ` Patrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109170239.56a4e727@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.