From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Bill Paul <wpaul@windriver.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] e1000: document ICS read behaviour
Date: Thu, 10 Jan 2013 12:17:14 +0200 [thread overview]
Message-ID: <20130110101713.GA13451@redhat.com> (raw)
In-Reply-To: <20130110082647.GA20559@stefanha-thinkpad.redhat.com>
On Thu, Jan 10, 2013 at 09:26:47AM +0100, Stefan Hajnoczi wrote:
> On Thu, Jan 10, 2013 at 12:01:22AM +0200, Michael S. Tsirkin wrote:
> > Add code comment to clarify the reason we set ICS with ICR:
> > the reason was previously undocumented and git
> > log (commit b1332393cdd7d023de8f1f8aa136ee7866a18968)
> > confused rather than clarified the comments.
> > Digging in the mailing list archives gives the real reason
> > https://lists.gnu.org/archive/html/qemu-devel/2009-06/msg00401.html
> >
> > Add code comment with an explanation supplied by Bill Paul.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > hw/e1000.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
>
> Thanks, applied to the net tree:
> https://github.com/stefanha/qemu/commits/net
>
> Stefan
Actually I'm going to send v2 with a minor tweak.
next prev parent reply other threads:[~2013-01-10 10:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 22:01 [Qemu-devel] [PATCH] e1000: document ICS read behaviour Michael S. Tsirkin
2013-01-10 8:26 ` Stefan Hajnoczi
2013-01-10 10:17 ` Michael S. Tsirkin [this message]
2013-01-10 11:50 ` Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2013-01-10 12:03 Michael S. Tsirkin
2013-01-10 12:08 ` Michael S. Tsirkin
2013-01-11 9:30 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110101713.GA13451@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jasowang@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wpaul@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.