From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Fix RGB color range property for
 PCH platforms
Date: Thu, 10 Jan 2013 13:10:37 +0200
Message-ID: <20130110111037.GA3867@intel.com>
References: <1357756604-9268-1-git-send-email-ville.syrjala@linux.intel.com>
	<CAKMK7uGN2QtyaJhrVj4mZbViio5q69ii+KQ8OGUZb57sknsjfQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id 53E05E5C73
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 10 Jan 2013 03:10:43 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CAKMK7uGN2QtyaJhrVj4mZbViio5q69ii+KQ8OGUZb57sknsjfQ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jan 09, 2013 at 07:49:07PM +0100, Daniel Vetter wrote:
> On Wed, Jan 9, 2013 at 7:36 PM,  <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> >
> > The RGB color range select bit on the DP/SDVO/HDMI registers
> > disappeared when PCH was introduced, and instead a new PIPECONF bit
> > was added that performs the same function.
> >
> > Add a new intel_encoder function pointer to query the encoder whether
> > limited or full range should be selected, and set the PIPECONF bit 13
> > accordingly.
> >
> > Experimentation showed that simply toggling the bit while the pipe is
> > active doesn't work. We need to restart the pipe, which luckily already
> > happens.
> >
> > The DP/SDVO/HDMI bit 8 is marked MBZ in the docs, so avoid setting it,
> > although it doesn't seem to do any harm in practice.
> >
> > TODO:
> > - the PIPECONF bit too seems to have disappeared from HSW. Need a
> >   volunteer to test if it's just a documentation issue or if it's really
> >   gone. If the bit is gone and no easy replacement is found, then I sup=
pose
> >   we may need to use the pipe CSC unit to perform the range compression.
> > - move color_range to intel_encoder to avoid the silly func pointer?
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D46800
> > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> Can't we just add another flag to mod->private_flags like we do for
> 6bpc dithering? I know that that's ugly, and we need to extend this
> into a more generic pipe configuration struct, but we have way to many
> bits&pieces where encoders want to control/influence pipe state like
> that, so adding new virtual functions like this wont scale.

Right. private_flags seems like a decent way to handle this.
v2 coming up soon.

-- =

Ville Syrj=E4l=E4
Intel OTC