From: Stefan Hajnoczi <stefanha@gmail.com>
To: Luigi Rizzo <rizzo@iet.unipi.it>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] unbounded qemu NetQue's ?
Date: Thu, 10 Jan 2013 13:29:19 +0100 [thread overview]
Message-ID: <20130110122919.GC30946@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <CA+hQ2+iQhvGqtSHMBqLeZMhgJmk9WAHrOpteRHNEaE4uEkaSZQ@mail.gmail.com>
On Mon, Jan 07, 2013 at 03:27:30PM +0100, Luigi Rizzo wrote:
> On Mon, Jan 7, 2013 at 2:49 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>
> > On Sun, Jan 06, 2013 at 08:23:56PM +0100, Luigi Rizzo wrote:
> > diff -urp qemu-1.3.0-orig/net/queue.c qemu-1.3.0/net/queue.c
> > > --- qemu-1.3.0-orig/net/queue.c 2012-12-03 20:37:05.000000000+0100
> > > +++ qemu-1.3.0/net/queue.c 2013-01-06 19:38:12.000000000 +0100
> > > @@ -92,6 +92,9 @@ static void qemu_net_queue_append(NetQue
> >
> > Please also do it for qemu_net_queue_append_iov().
> >
> >
> the qemu code has many duplicate functions of the form foo() and foo_iov() .
> Not only here, but even in the backents (e.g. see net/tap.c)
> I think it would be good to settle on a single version of the function
> and remove or convert the non-iov instances.
Yes. Patches welcome.
Stefan
next prev parent reply other threads:[~2013-01-10 12:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 19:23 [Qemu-devel] unbounded qemu NetQue's ? Luigi Rizzo
2013-01-07 13:49 ` Stefan Hajnoczi
2013-01-07 14:27 ` Luigi Rizzo
2013-01-10 12:29 ` Stefan Hajnoczi [this message]
2013-01-16 21:57 ` Luigi Rizzo
2013-01-17 6:07 ` [Qemu-devel] [PATCH] fix unbounded qemu NetQueue Luigi Rizzo
2013-01-17 10:21 ` Stefan Hajnoczi
2013-01-17 15:56 ` Luigi Rizzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110122919.GC30946@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rizzo@iet.unipi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.