From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH v5 2/3] sta2x11_vip: convert to videobuf2 and control framework Date: Thu, 10 Jan 2013 17:01:50 +0300 Message-ID: <20130110140150.GA19949@mwanda> References: <1357822010-30419-1-git-send-email-federico.vaga@gmail.com> <1357822010-30419-3-git-send-email-federico.vaga@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1357822010-30419-3-git-send-email-federico.vaga@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devel-bounces@linuxdriverproject.org Sender: "devel" To: Federico Vaga Cc: Kamil Debski , Mauro Carvalho Chehab , Srinivas Kandagatla , Sungchun Kang , Peter Senna Tschudin , Laurent Pinchart , Marek Szyprowski , devel@driverdev.osuosl.org, Giancarlo Asnaghi , linux-samsung-soc@vger.kernel.org, Jonathan Corbet , Sachin Kamat , Prabhakar Lad , Hans Verkuil , Sasha Levin , linux-media@vger.kernel.org, Tomasz Stanislawski , Pawel Osciak , Scott Jiang , Mauro Carvalho Chehab , Jeongtae Park Andrzej Pietrasiewicz List-Id: linux-samsung-soc@vger.kernel.org This would be easier to review if it were broken up into separate patches. 1) There are superflous white spaces changes 2) Changes to the copyright 3) pr_warning => pr_warn 4) The REG_READ and REG_WRITE macros are now inline functions 5) KBUILD_MODNAME is used instead of DRV_NAME 6) It now uses the video_drvdata() function 7) Lots of comments deleted. For exmple, vidioc_enum_fmt_vid_cap() didn't change. Just the comments were deleted. 8) Comments added for existing code. 9) Other behavior changes not related to using videobuf2 like in vidioc_try_fmt_vid_cap(). 10) etc... If all the uninteresting changes are in separate patches it makes the complicated stuff much shorter and easier to review. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: dan.carpenter@oracle.com (Dan Carpenter) Date: Thu, 10 Jan 2013 17:01:50 +0300 Subject: [PATCH v5 2/3] sta2x11_vip: convert to videobuf2 and control framework In-Reply-To: <1357822010-30419-3-git-send-email-federico.vaga@gmail.com> References: <1357822010-30419-1-git-send-email-federico.vaga@gmail.com> <1357822010-30419-3-git-send-email-federico.vaga@gmail.com> Message-ID: <20130110140150.GA19949@mwanda> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org This would be easier to review if it were broken up into separate patches. 1) There are superflous white spaces changes 2) Changes to the copyright 3) pr_warning => pr_warn 4) The REG_READ and REG_WRITE macros are now inline functions 5) KBUILD_MODNAME is used instead of DRV_NAME 6) It now uses the video_drvdata() function 7) Lots of comments deleted. For exmple, vidioc_enum_fmt_vid_cap() didn't change. Just the comments were deleted. 8) Comments added for existing code. 9) Other behavior changes not related to using videobuf2 like in vidioc_try_fmt_vid_cap(). 10) etc... If all the uninteresting changes are in separate patches it makes the complicated stuff much shorter and easier to review. regards, dan carpenter