All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: linux-kernel@vger.kernel.org
Cc: gaowanlong@cn.fujitsu.com, alan@linux.intel.com,
	gregkh@linuxfoundation.org, frank@lichtenheld.de
Subject: regression, bisected: openpty fails from 3.7 onwards without devpts
Date: Thu, 10 Jan 2013 15:46:26 +0100	[thread overview]
Message-ID: <20130110144626.GA26279@breakpoint.cc> (raw)

Frank Lichtenheld discovered that openpty() doesn't work anymore when
/dev/pts is not present.

We bisected this down to

commit bbb63c514a3464342967237a51a21ea8f61ab951
Author: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Subject: drivers:tty:fix up ENOIOCTLCMD error handling

The original program triggering the error was pptpd, but
the test program below is sufficient:
----
#include <stdio.h>
#include <pty.h>
int main(void) {
 int pty_fd, tty_fd;
 if (openpty(&pty_fd, &tty_fd, NULL, NULL, NULL) != 0) {
  perror("openpty");
  return 1;
 }
return 0;
}
----
[ compile with cc -lutil pty.c -o pty ]

If devpts is available or above commit reverted openpty works again.

             reply	other threads:[~2013-01-10 14:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10 14:46 Florian Westphal [this message]
2013-01-10 15:50 ` regression, bisected: openpty fails from 3.7 onwards without devpts Alan Cox
2013-01-10 16:29   ` Florian Westphal
2013-01-10 17:23     ` Jiri Slaby
2013-01-10 20:13       ` Jiri Slaby
2013-01-10 22:45       ` Alan Cox
2013-01-10 22:51         ` Jiri Slaby
2013-01-11 11:11           ` Jiri Slaby
2013-01-11 12:41             ` Florian Westphal
2013-01-11 12:44               ` Jiri Slaby
2013-01-11 13:18                 ` Alan Cox
2013-01-17 16:29                   ` Greg KH
2013-01-17 16:34                     ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130110144626.GA26279@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=alan@linux.intel.com \
    --cc=frank@lichtenheld.de \
    --cc=gaowanlong@cn.fujitsu.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.