From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] pkg-infra: add <pkg>_CONFIG_FIXUP to fix *-config files
Date: Thu, 10 Jan 2013 21:19:26 +0100 [thread overview]
Message-ID: <20130110211926.564113ba@skate> (raw)
In-Reply-To: <1357847559-31530-2-git-send-email-stefan.froberg@petroprogram.com>
Dear Stefan Fr?berg,
On Thu, 10 Jan 2013 21:52:39 +0200, Stefan Fr?berg wrote:
> For example:
>
> DIVINE_CONFIG_FIXUP = divine-config
>
> or for multiple files:
>
> IMAGEMAGICK_CONFIG_FIXUP = Magick-config Wand-config
I personally still believe that it is wrong to give just the filename
here and not the full path, i.e:
IMAGEMAGICK_CONFIG_FIXUP = \
$(STAGING_DIR)/usr/bin/Magick-config \
$(SATGING_DIR)/usr/bin/Wand-config
With just the filename, my impression is that it is just too much magic
happening behind the scene.
That said, I would not oppose to the current solution being integrated.
I'm just sharing a preference, not a strong opposition here.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-01-10 20:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 19:52 [Buildroot] [PATCH v2] pkg-infra: add <pkg>_CONFIG_FIXUP to fix *-config files Stefan Fröberg
2013-01-10 19:52 ` Stefan Fröberg
2013-01-10 20:19 ` Thomas Petazzoni [this message]
2013-01-10 20:47 ` Yann E. MORIN
2013-01-10 21:15 ` Stefan Fröberg
2013-01-10 21:22 ` Yann E. MORIN
2013-01-10 21:01 ` Stefan Fröberg
2013-01-11 21:33 ` Arnout Vandecappelle
2013-01-12 1:38 ` Stefan Fröberg
2013-01-17 8:32 ` Arnout Vandecappelle
2013-01-18 12:58 ` Stefan Fröberg
2013-01-18 15:23 ` Thomas Petazzoni
2013-01-18 17:55 ` Stefan Fröberg
2013-01-18 15:51 ` Arnout Vandecappelle
2013-01-18 17:52 ` Stefan Fröberg
2013-01-20 11:36 ` Arnout Vandecappelle
2013-01-20 12:35 ` Samuel Martin
2013-01-20 14:37 ` Stefan Fröberg
2013-01-20 17:27 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110211926.564113ba@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.