From: Dan Carpenter <dan.carpenter@oracle.com>
To: mickflemm@gmail.com
Cc: linux-wireless@vger.kernel.org, ath5k-devel@lists.ath5k.org
Subject: re: ath5k: Extend get_default_sifs/slot_time
Date: Fri, 11 Jan 2013 09:57:01 +0300 [thread overview]
Message-ID: <20130111065701.GF13207@elgon.mountain> (raw)
Hello Nick Kossifidis,
The patch 3017fcab416d: "ath5k: Extend get_default_sifs/slot_time"
from Nov 23, 2010, leads to the following warning:
drivers/net/wireless/ath/ath5k/pcu.c:223 ath5k_hw_get_default_sifs()
warn: missing break? reassigning 'sifs'
209 switch (ah->ah_bwmode) {
210 case AR5K_BWMODE_40MHZ:
211 sifs = AR5K_INIT_SIFS_TURBO;
212 break;
213 case AR5K_BWMODE_10MHZ:
214 sifs = AR5K_INIT_SIFS_HALF_RATE;
215 break;
216 case AR5K_BWMODE_5MHZ:
217 sifs = AR5K_INIT_SIFS_QUARTER_RATE;
218 break;
219 case AR5K_BWMODE_DEFAULT:
220 sifs = AR5K_INIT_SIFS_DEFAULT_BG;
221 default:
Was it intentional to fall through to the default case here? Most of
the intentional fall through sites (80-90%) have a /* fall through */
comment.
222 if (channel->band == IEEE80211_BAND_5GHZ)
223 sifs = AR5K_INIT_SIFS_DEFAULT_A;
224 break;
225 }
regards,
dan carpenter
next reply other threads:[~2013-01-11 6:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 6:57 Dan Carpenter [this message]
2013-01-12 3:31 ` ath5k: Extend get_default_sifs/slot_time Nick Kossifidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130111065701.GF13207@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.