From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>,
Glauber Costa <glommer@parallels.com>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
elezegarcia@gmail.com
Subject: Re: REN2 [09/13] Common function to create the kmalloc array
Date: Fri, 11 Jan 2013 16:23:55 +0900 [thread overview]
Message-ID: <20130111072355.GA2346@lge.com> (raw)
In-Reply-To: <0000013c25e08975-f7fd7592-7d64-409c-874d-d00ea2106f2e-000000@email.amazonses.com>
Hello, Christoph.
On Thu, Jan 10, 2013 at 07:12:17PM +0000, Christoph Lameter wrote:
> The kmalloc array is created in similar ways in both SLAB
> and SLUB. Create a common function and have both allocators
> call that function.
>
> V1->V2:
> Whitespace cleanup
>
> Reviewed-by: Glauber Costa <glommer@parallels.com>
> Signed-off-by: Christoph Lameter <cl@linux.com>
>
> Index: linux/mm/slab.c
> ===================================================================
> --- linux.orig/mm/slab.c 2013-01-10 09:55:49.493734836 -0600
> +++ linux/mm/slab.c 2013-01-10 09:55:50.169745534 -0600
> @@ -1625,30 +1625,6 @@ void __init kmem_cache_init(void)
>
> slab_early_init = 0;
>
> - for (i = 1; i < PAGE_SHIFT + MAX_ORDER; i++) {
> - size_t cs_size = kmalloc_size(i);
> -
> - if (cs_size < KMALLOC_MIN_SIZE)
> - continue;
> -
> - if (!kmalloc_caches[i]) {
> - /*
> - * For performance, all the general caches are L1 aligned.
> - * This should be particularly beneficial on SMP boxes, as it
> - * eliminates "false sharing".
> - * Note for systems short on memory removing the alignment will
> - * allow tighter packing of the smaller caches.
> - */
> - kmalloc_caches[i] = create_kmalloc_cache("kmalloc",
> - cs_size, ARCH_KMALLOC_FLAGS);
> - }
> -
> -#ifdef CONFIG_ZONE_DMA
> - kmalloc_dma_caches[i] = create_kmalloc_cache(
> - "kmalloc-dma", cs_size,
> - SLAB_CACHE_DMA|ARCH_KMALLOC_FLAGS);
> -#endif
> - }
> /* 4) Replace the bootstrap head arrays */
> {
> struct array_cache *ptr;
> @@ -1694,29 +1670,7 @@ void __init kmem_cache_init(void)
> }
> }
>
> - slab_state = UP;
> -
> - /* Create the proper names */
> - for (i = 1; i < PAGE_SHIFT + MAX_ORDER; i++) {
> - char *s;
> - struct kmem_cache *c = kmalloc_caches[i];
> -
> - if (!c)
> - continue;
> -
> - s = kasprintf(GFP_NOWAIT, "kmalloc-%d", kmalloc_size(i));
> -
> - BUG_ON(!s);
> - c->name = s;
> -
> -#ifdef CONFIG_ZONE_DMA
> - c = kmalloc_dma_caches[i];
> - BUG_ON(!c);
> - s = kasprintf(GFP_NOWAIT, "dma-kmalloc-%d", kmalloc_size(i));
> - BUG_ON(!s);
> - c->name = s;
> -#endif
> - }
> + create_kmalloc_caches(ARCH_KMALLOC_FLAGS);
> }
>
> void __init kmem_cache_init_late(void)
> Index: linux/mm/slab.h
> ===================================================================
> --- linux.orig/mm/slab.h 2013-01-10 09:54:18.000315420 -0600
> +++ linux/mm/slab.h 2013-01-10 09:55:50.169745534 -0600
> @@ -35,6 +35,12 @@ extern struct kmem_cache *kmem_cache;
> unsigned long calculate_alignment(unsigned long flags,
> unsigned long align, unsigned long size);
>
> +#ifndef CONFIG_SLOB
> +/* Kmalloc array related functions */
> +void create_kmalloc_caches(unsigned long);
> +#endif
> +
> +
> /* Functions provided by the slab allocators */
> extern int __kmem_cache_create(struct kmem_cache *, unsigned long flags);
>
> Index: linux/mm/slab_common.c
> ===================================================================
> --- linux.orig/mm/slab_common.c 2013-01-10 09:55:49.489734859 -0600
> +++ linux/mm/slab_common.c 2013-01-10 09:55:50.169745534 -0600
> @@ -327,6 +327,60 @@ struct kmem_cache *kmalloc_dma_caches[KM
> EXPORT_SYMBOL(kmalloc_dma_caches);
> #endif
>
> +/*
> + * Create the kmalloc array. Some of the regular kmalloc arrays
> + * may already have been created because they were needed to
> + * enable allocations for slab creation.
> + */
> +void __init create_kmalloc_caches(unsigned long flags)
> +{
> + int i;
> +
> + /* Caches that are not of the two-to-the-power-of size */
> + if (KMALLOC_MIN_SIZE <= 32 && !kmalloc_caches[1])
> + kmalloc_caches[1] = create_kmalloc_cache(NULL, 96, flags);
> +
> + if (KMALLOC_MIN_SIZE <= 64 && !kmalloc_caches[2])
> + kmalloc_caches[2] = create_kmalloc_cache(NULL, 192, flags);
> +
> + for (i = KMALLOC_SHIFT_LOW; i <= KMALLOC_SHIFT_HIGH; i++)
> + if (!kmalloc_caches[i])
> + kmalloc_caches[i] = create_kmalloc_cache(NULL,
> + 1 << i, flags);
> +
In case of the SLUB, create_kmalloc_cache with @NULL break the system
if slub_debug is used.
Call flow is like as below.
create_kmalloc_cache -> create_boot_cache -> __kmem_cache_create ->
kmem_cache_open -> kmem_cache_flag.
In kmem_cache_flag, strncmp is excecuted with name, that is, NULL.
> + /* Kmalloc array is now usable */
> + slab_state = UP;
> +
> + for (i = 0; i <= KMALLOC_SHIFT_HIGH; i++) {
> + struct kmem_cache *s = kmalloc_caches[i];
> + char *n;
> +
> + if (s) {
> + n = kasprintf(GFP_NOWAIT, "kmalloc-%d", kmalloc_size(i));
> +
> + BUG_ON(!n);
> + s->name = n;
> + }
> + }
> +
> +#ifdef CONFIG_ZONE_DMA
> + for (i = 0; i <= KMALLOC_SHIFT_HIGH; i++) {
> + struct kmem_cache *s = kmalloc_caches[i];
> +
> + if (s) {
> + int size = kmalloc_size(i);
> + char *n = kasprintf(GFP_NOWAIT,
> + "dma-kmalloc-%d", size);
> +
> + BUG_ON(!n);
> + kmalloc_dma_caches[i] = create_kmalloc_cache(n,
> + size, SLAB_CACHE_DMA | flags);
> + }
> + }
> +#endif
> +}
> +
> +
> #endif /* !CONFIG_SLOB */
>
>
> Index: linux/mm/slub.c
> ===================================================================
> --- linux.orig/mm/slub.c 2013-01-10 09:55:49.489734859 -0600
> +++ linux/mm/slub.c 2013-01-10 09:55:50.173745560 -0600
> @@ -3633,7 +3633,6 @@ void __init kmem_cache_init(void)
> static __initdata struct kmem_cache boot_kmem_cache,
> boot_kmem_cache_node;
> int i;
> - int caches = 2;
>
> if (debug_guardpage_minorder())
> slub_max_order = 0;
> @@ -3703,64 +3702,16 @@ void __init kmem_cache_init(void)
> size_index[size_index_elem(i)] = 8;
> }
>
> - /* Caches that are not of the two-to-the-power-of size */
> - if (KMALLOC_MIN_SIZE <= 32) {
> - kmalloc_caches[1] = create_kmalloc_cache("kmalloc-96", 96, 0);
> - caches++;
> - }
> -
> - if (KMALLOC_MIN_SIZE <= 64) {
> - kmalloc_caches[2] = create_kmalloc_cache("kmalloc-192", 192, 0);
> - caches++;
> - }
> -
> - for (i = KMALLOC_SHIFT_LOW; i <= KMALLOC_SHIFT_HIGH; i++) {
> - kmalloc_caches[i] = create_kmalloc_cache("kmalloc", 1 << i, 0);
> - caches++;
> - }
> -
> - slab_state = UP;
> -
> - /* Provide the correct kmalloc names now that the caches are up */
> - if (KMALLOC_MIN_SIZE <= 32) {
> - kmalloc_caches[1]->name = kstrdup(kmalloc_caches[1]->name, GFP_NOWAIT);
> - BUG_ON(!kmalloc_caches[1]->name);
> - }
> -
> - if (KMALLOC_MIN_SIZE <= 64) {
> - kmalloc_caches[2]->name = kstrdup(kmalloc_caches[2]->name, GFP_NOWAIT);
> - BUG_ON(!kmalloc_caches[2]->name);
> - }
> -
> - for (i = KMALLOC_SHIFT_LOW; i <= KMALLOC_SHIFT_HIGH; i++) {
> - char *s = kasprintf(GFP_NOWAIT, "kmalloc-%d", 1 << i);
> -
> - BUG_ON(!s);
> - kmalloc_caches[i]->name = s;
> - }
> + create_kmalloc_caches(0);
>
> #ifdef CONFIG_SMP
> register_cpu_notifier(&slab_notifier);
> #endif
>
> -#ifdef CONFIG_ZONE_DMA
> - for (i = 0; i <= KMALLOC_SHIFT_HIGH; i++) {
> - struct kmem_cache *s = kmalloc_caches[i];
> -
> - if (s && s->size) {
> - char *name = kasprintf(GFP_NOWAIT,
> - "dma-kmalloc-%d", s->object_size);
> -
> - BUG_ON(!name);
> - kmalloc_dma_caches[i] = create_kmalloc_cache(name,
> - s->object_size, SLAB_CACHE_DMA);
> - }
> - }
> -#endif
> printk(KERN_INFO
> - "SLUB: Genslabs=%d, HWalign=%d, Order=%d-%d, MinObjects=%d,"
> + "SLUB: HWalign=%d, Order=%d-%d, MinObjects=%d,"
> " CPUs=%d, Nodes=%d\n",
> - caches, cache_line_size(),
> + cache_line_size(),
> slub_min_order, slub_max_order, slub_min_objects,
> nr_cpu_ids, nr_node_ids);
> }
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-11 7:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130110190027.780479755@linux.com>
2013-01-10 19:00 ` REN2 [02/13] Move kmalloc related function defs Christoph Lameter
2013-01-10 19:00 ` REN2 [01/13] slab_common: Use proper formatting specs for unsigned size_t Christoph Lameter
2013-01-10 19:12 ` REN2 [08/13] Common definition for the array of kmalloc caches Christoph Lameter
2013-01-10 19:12 ` REN2 [05/13] slab: Common name for the per node structures Christoph Lameter
2013-01-10 19:12 ` REN2 [09/13] Common function to create the kmalloc array Christoph Lameter
2013-01-11 7:23 ` Joonsoo Kim [this message]
2013-01-14 14:46 ` Christoph Lameter
[not found] ` <alpine.DEB.2.02.1301140843010.27095@gentwo.org>
2013-01-14 19:50 ` Christoph Lameter
2013-01-10 19:14 ` REN2 [10/13] stat: Use size_t for sizes instead of unsigned Christoph Lameter
2013-01-10 19:14 ` REN2 [04/13] slab: Use common kmalloc_index/kmalloc_size functions Christoph Lameter
2013-01-10 19:14 ` REN2 [06/13] slab: rename nodelists to node Christoph Lameter
2013-01-10 19:14 ` REN2 [11/13] Common Kmalloc cache determination Christoph Lameter
2013-01-10 19:14 ` REN2 [07/13] Common constants for kmalloc boundaries Christoph Lameter
2013-02-02 18:00 ` Ezequiel Garcia
2013-02-04 19:36 ` Christoph Lameter
2013-01-10 19:14 ` REN2 [13/13] Common definition for kmem_cache_node Christoph Lameter
2013-01-10 19:14 ` REN2 [12/13] slab: Rename list3/l3 to node Christoph Lameter
2013-01-10 19:14 ` REN2 [03/13] Common kmalloc slab index determination Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130111072355.GA2346@lge.com \
--to=iamjoonsoo.kim@lge.com \
--cc=cl@linux.com \
--cc=elezegarcia@gmail.com \
--cc=glommer@parallels.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.