From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Misael Lopez Cruz <misael.lopez@ti.com>,
Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/5] ASoC: twl6040: Prevent extra power transitions during resume
Date: Fri, 11 Jan 2013 11:52:07 +0000 [thread overview]
Message-ID: <20130111115207.GW20956@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1357900355-5055-3-git-send-email-peter.ujfalusi@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 606 bytes --]
On Fri, Jan 11, 2013 at 11:32:32AM +0100, Peter Ujfalusi wrote:
> - twl6040_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
> - twl6040_set_bias_level(codec, codec->dapm.suspend_bias_level);
> + if (codec->dapm.bias_level != codec->dapm.suspend_bias_level) {
> + twl6040_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
> + twl6040_set_bias_level(codec, codec->dapm.suspend_bias_level);
> + }
The device should always be in either _STANDBY or _OFF (depending on if
it supports idle_bias_off) before it tries to suspend so
suspend_bias_level ought to be redundant. We should really get round to
killing it...
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-01-11 11:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 10:32 [PATCH 0/5] ASoC: twl6040: Updates for 3.9 Peter Ujfalusi
2013-01-11 10:32 ` [PATCH 1/5] ASoC: twl6040: Convert PLUGINT to no-suspend irq Peter Ujfalusi
2013-01-11 10:32 ` [PATCH 2/5] ASoC: twl6040: Prevent extra power transitions during resume Peter Ujfalusi
2013-01-11 11:52 ` Mark Brown [this message]
2013-01-11 13:40 ` Peter Ujfalusi
2013-01-11 13:46 ` Mark Brown
2013-01-11 13:55 ` Peter Ujfalusi
2013-01-11 14:24 ` Mark Brown
2013-01-11 14:44 ` Peter Ujfalusi
2013-01-11 15:02 ` Mark Brown
2013-01-11 10:32 ` [PATCH 3/5] ASoC: twl6040: Convert to use devm_* when possible Peter Ujfalusi
2013-01-11 10:32 ` [PATCH 4/5] ASoC: twl6040: Switch to use system workqueue for jack reporting Peter Ujfalusi
2013-01-11 10:32 ` [PATCH 5/5] ASoC: twl6040: Remove leftover code from hs/hf ramp implementation Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130111115207.GW20956@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.