From: Ben Myers <bpm@sgi.com>
To: Abhijit Pawar <abhi.c.pawar@gmail.com>
Cc: Jeff Liu <jeff.liu@oracle.com>, Alex Elder <elder@kernel.org>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 1/1] fs/xfs remove obsolete simple_strto<foo>
Date: Fri, 11 Jan 2013 13:09:00 -0600 [thread overview]
Message-ID: <20130111190900.GA27055@sgi.com> (raw)
In-Reply-To: <50EFC356.10908@gmail.com>
Hey,
On Fri, Jan 11, 2013 at 01:16:30PM +0530, Abhijit Pawar wrote:
> On 01/11/2013 12:06 PM, Jeff Liu wrote:
> > On 01/09/2013 10:04 PM, Abhijit Pawar wrote:
> >> This patch replaces usages of obsolete simple_strtoul with kstrtoint in xfs_args and suffix_strtoul.
> >>
> >> Signed-off-by: Abhijit Pawar <abhi.c.pawar@gmail.com>
> > checkpatch.pl show warning if we return EINVAL as below:
> > WARNING: return of an errno should typically be -ve (return -EINVAL)
> >
> > Can we just ignore such code style issue?
> I think we can.
> Ben?
Yep, no worries.
Regards,
Ben
next prev parent reply other threads:[~2013-01-11 19:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 14:04 [PATCH 1/1] fs/xfs remove obsolete simple_strto<foo> Abhijit Pawar
2013-01-11 6:36 ` Jeff Liu
2013-01-11 7:46 ` Abhijit Pawar
2013-01-11 19:09 ` Ben Myers [this message]
2013-01-11 22:52 ` Dave Chinner
2013-01-12 2:48 ` Jeff Liu
2013-01-12 2:54 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130111190900.GA27055@sgi.com \
--to=bpm@sgi.com \
--cc=abhi.c.pawar@gmail.com \
--cc=elder@kernel.org \
--cc=jeff.liu@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.