From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH v5 6/5] KVM: x86: clear write_fault_to_shadow_pgtable
 explicitly
Date: Fri, 11 Jan 2013 17:09:56 -0200
Message-ID: <20130111190956.GB17216@amt.cnet>
References: <50EBBE54.1040007@linux.vnet.ibm.com>
 <50EBBEEC.2060100@linux.vnet.ibm.com>
 <20130110173036.GB24703@amt.cnet>
 <50EF056B.4040803@linux.vnet.ibm.com>
 <20130111131511.GA18558@amt.cnet>
 <50F01DEA.6000005@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Gleb Natapov <gleb@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <50F01DEA.6000005@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Fri, Jan 11, 2013 at 10:12:58PM +0800, Xiao Guangrong wrote:
> On 01/11/2013 09:15 PM, Marcelo Tosatti wrote:
> 
> > 
> > This is cryptic. Its not obvious at all for someone modifying the code, 
> > for example.
> > 
> > Can you please clear it explicitly? 
> 
> Sure, this is the patch to apply your idea, is it good to you? :)
> 
> ============================================
> Subject: [PATCH 6/6] KVM: x86: clear write_fault_to_shadow_pgtable explicitly
> 
> Clear it explicitly when exiting x86_emulate_instruction to clarify the code,
> it is suggested by Marcelo
> 
> Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
> ---
>  arch/x86/kvm/x86.c |   16 ++++++++++++----
>  1 files changed, 12 insertions(+), 4 deletions(-)

Fine, please rebase against queue.